Diff of the two buildlogs: -- --- b1/build.log 2022-02-10 13:26:58.664689709 +0000 +++ b2/build.log 2022-02-10 13:27:34.147593180 +0000 @@ -1,6 +1,6 @@ I: pbuilder: network access will be disabled during build -I: Current time: Thu Feb 10 01:26:00 -12 2022 -I: pbuilder-time-stamp: 1644499560 +I: Current time: Thu Mar 16 09:50:00 +14 2023 +I: pbuilder-time-stamp: 1678909800 I: Building the build Environment I: extracting base tarball [/var/cache/pbuilder/bullseye-reproducible-base.tgz] I: copying local configuration @@ -16,8 +16,8 @@ I: copying [./pads_1.2-12.debian.tar.xz] I: Extracting source gpgv: unknown type of key resource 'trustedkeys.kbx' -gpgv: keyblock resource '/tmp/dpkg-verify-sig.Pv1PwKgi/trustedkeys.kbx': General error -gpgv: Signature made Sun Jan 19 08:42:40 2020 -12 +gpgv: keyblock resource '/tmp/dpkg-verify-sig.BH2TY4y5/trustedkeys.kbx': General error +gpgv: Signature made Mon Jan 20 10:42:40 2020 +14 gpgv: using RSA key 9236557B170C87F8821C0AC3C1E0D92E986F7C7E gpgv: Can't check signature: No public key dpkg-source: warning: failed to verify signature on ./pads_1.2-12.dsc @@ -29,135 +29,169 @@ dpkg-source: info: applying fix_linker.patch I: Not using root during the build. I: Installing the build-deps -I: user script /srv/workspace/pbuilder/379961/tmp/hooks/D02_print_environment starting +I: user script /srv/workspace/pbuilder/3443830/tmp/hooks/D01_modify_environment starting +debug: Running on ionos15-amd64. +I: Changing host+domainname to test build reproducibility +I: Adding a custom variable just for the fun of it... +I: Changing /bin/sh to bash +Removing 'diversion of /bin/sh to /bin/sh.distrib by dash' +Adding 'diversion of /bin/sh to /bin/sh.distrib by bash' +Removing 'diversion of /usr/share/man/man1/sh.1.gz to /usr/share/man/man1/sh.distrib.1.gz by dash' +Adding 'diversion of /usr/share/man/man1/sh.1.gz to /usr/share/man/man1/sh.distrib.1.gz by bash' +I: Setting pbuilder2's login shell to /bin/bash +I: Setting pbuilder2's GECOS to second user,second room,second work-phone,second home-phone,second other +I: user script /srv/workspace/pbuilder/3443830/tmp/hooks/D01_modify_environment finished +I: user script /srv/workspace/pbuilder/3443830/tmp/hooks/D02_print_environment starting I: set - BUILDDIR='/build' - BUILDUSERGECOS='first user,first room,first work-phone,first home-phone,first other' - BUILDUSERNAME='pbuilder1' - BUILD_ARCH='amd64' - DEBIAN_FRONTEND='noninteractive' - DEB_BUILD_OPTIONS='buildinfo=+all reproducible=+all,-fixfilepath parallel=15' - DISTRIBUTION='' - HOME='/root' - HOST_ARCH='amd64' + BASH=/bin/sh + BASHOPTS=checkwinsize:cmdhist:complete_fullquote:extquote:force_fignore:globasciiranges:hostcomplete:interactive_comments:progcomp:promptvars:sourcepath + BASH_ALIASES=() + BASH_ARGC=() + BASH_ARGV=() + BASH_CMDS=() + BASH_LINENO=([0]="12" [1]="0") + BASH_SOURCE=([0]="/tmp/hooks/D02_print_environment" [1]="/tmp/hooks/D02_print_environment") + BASH_VERSINFO=([0]="5" [1]="1" [2]="4" [3]="1" [4]="release" [5]="x86_64-pc-linux-gnu") + BASH_VERSION='5.1.4(1)-release' + BUILDDIR=/build + BUILDUSERGECOS='second user,second room,second work-phone,second home-phone,second other' + BUILDUSERNAME=pbuilder2 + BUILD_ARCH=amd64 + DEBIAN_FRONTEND=noninteractive + DEB_BUILD_OPTIONS='buildinfo=+all reproducible=+all,-fixfilepath parallel=16' + DIRSTACK=() + DISTRIBUTION= + EUID=0 + FUNCNAME=([0]="Echo" [1]="main") + GROUPS=() + HOME=/root + HOSTNAME=i-capture-the-hostname + HOSTTYPE=x86_64 + HOST_ARCH=amd64 IFS=' ' - INVOCATION_ID='7f51d9aeffff466db43379ca833d595c' - LANG='C' - LANGUAGE='en_US:en' - LC_ALL='C' - MAIL='/var/mail/root' - OPTIND='1' - PATH='/usr/sbin:/usr/bin:/sbin:/bin:/usr/games' - PBCURRENTCOMMANDLINEOPERATION='build' - PBUILDER_OPERATION='build' - PBUILDER_PKGDATADIR='/usr/share/pbuilder' - PBUILDER_PKGLIBDIR='/usr/lib/pbuilder' - PBUILDER_SYSCONFDIR='/etc' - PPID='379961' - PS1='# ' - PS2='> ' + INVOCATION_ID=93021c0f08b44101aeed67ccb32a3921 + LANG=C + LANGUAGE=et_EE:et + LC_ALL=C + MACHTYPE=x86_64-pc-linux-gnu + MAIL=/var/mail/root + OPTERR=1 + OPTIND=1 + OSTYPE=linux-gnu + PATH=/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/i/capture/the/path + PBCURRENTCOMMANDLINEOPERATION=build + PBUILDER_OPERATION=build + PBUILDER_PKGDATADIR=/usr/share/pbuilder + PBUILDER_PKGLIBDIR=/usr/lib/pbuilder + PBUILDER_SYSCONFDIR=/etc + PIPESTATUS=([0]="0") + POSIXLY_CORRECT=y + PPID=3443830 PS4='+ ' - PWD='/' - SHELL='/bin/bash' - SHLVL='2' - SUDO_COMMAND='/usr/bin/timeout -k 18.1h 18h /usr/bin/ionice -c 3 /usr/bin/nice /usr/sbin/pbuilder --build --configfile /srv/reproducible-results/rbuild-debian/tmp.fwFQ4VJmyJ/pbuilderrc_vPNQ --hookdir /etc/pbuilder/first-build-hooks --debbuildopts -b --basetgz /var/cache/pbuilder/bullseye-reproducible-base.tgz --buildresult /srv/reproducible-results/rbuild-debian/tmp.fwFQ4VJmyJ/b1 --logfile b1/build.log pads_1.2-12.dsc' - SUDO_GID='111' - SUDO_UID='106' - SUDO_USER='jenkins' - TERM='unknown' - TZ='/usr/share/zoneinfo/Etc/GMT+12' - USER='root' - _='/usr/bin/systemd-run' - http_proxy='http://78.137.99.97:3128' + PWD=/ + SHELL=/bin/bash + SHELLOPTS=braceexpand:errexit:hashall:interactive-comments:posix + SHLVL=3 + SUDO_COMMAND='/usr/bin/timeout -k 24.1h 24h /usr/bin/ionice -c 3 /usr/bin/nice -n 11 /usr/bin/unshare --uts -- /usr/sbin/pbuilder --build --configfile /srv/reproducible-results/rbuild-debian/tmp.fwFQ4VJmyJ/pbuilderrc_toCN --hookdir /etc/pbuilder/rebuild-hooks --debbuildopts -b --basetgz /var/cache/pbuilder/bullseye-reproducible-base.tgz --buildresult /srv/reproducible-results/rbuild-debian/tmp.fwFQ4VJmyJ/b2 --logfile b2/build.log pads_1.2-12.dsc' + SUDO_GID=111 + SUDO_UID=106 + SUDO_USER=jenkins + TERM=unknown + TZ=/usr/share/zoneinfo/Etc/GMT-14 + UID=0 + USER=root + _='I: set' + http_proxy=http://85.184.249.68:3128 I: uname -a - Linux ionos11-amd64 5.10.0-11-amd64 #1 SMP Debian 5.10.92-1 (2022-01-18) x86_64 GNU/Linux + Linux i-capture-the-hostname 5.15.0-0.bpo.2-amd64 #1 SMP Debian 5.15.5-2~bpo11+1 (2022-01-02) x86_64 GNU/Linux I: ls -l /bin total 5476 - -rwxr-xr-x 1 root root 1234376 Aug 4 2021 bash - -rwxr-xr-x 3 root root 38984 Jul 20 2020 bunzip2 - -rwxr-xr-x 3 root root 38984 Jul 20 2020 bzcat - lrwxrwxrwx 1 root root 6 Jul 20 2020 bzcmp -> bzdiff - -rwxr-xr-x 1 root root 2225 Jul 20 2020 bzdiff - lrwxrwxrwx 1 root root 6 Jul 20 2020 bzegrep -> bzgrep - -rwxr-xr-x 1 root root 4877 Sep 4 2019 bzexe - lrwxrwxrwx 1 root root 6 Jul 20 2020 bzfgrep -> bzgrep - -rwxr-xr-x 1 root root 3775 Jul 20 2020 bzgrep - -rwxr-xr-x 3 root root 38984 Jul 20 2020 bzip2 - -rwxr-xr-x 1 root root 18424 Jul 20 2020 bzip2recover - lrwxrwxrwx 1 root root 6 Jul 20 2020 bzless -> bzmore - -rwxr-xr-x 1 root root 1297 Jul 20 2020 bzmore - -rwxr-xr-x 1 root root 43936 Sep 23 2020 cat - -rwxr-xr-x 1 root root 72672 Sep 23 2020 chgrp - -rwxr-xr-x 1 root root 64448 Sep 23 2020 chmod - -rwxr-xr-x 1 root root 72672 Sep 23 2020 chown - -rwxr-xr-x 1 root root 151168 Sep 23 2020 cp - -rwxr-xr-x 1 root root 125560 Dec 10 2020 dash - -rwxr-xr-x 1 root root 113664 Sep 23 2020 date - -rwxr-xr-x 1 root root 80968 Sep 23 2020 dd - -rwxr-xr-x 1 root root 93936 Sep 23 2020 df - -rwxr-xr-x 1 root root 147176 Sep 23 2020 dir - -rwxr-xr-x 1 root root 84440 Jul 28 2021 dmesg - lrwxrwxrwx 1 root root 8 Nov 6 2019 dnsdomainname -> hostname - lrwxrwxrwx 1 root root 8 Nov 6 2019 domainname -> hostname - -rwxr-xr-x 1 root root 39712 Sep 23 2020 echo - -rwxr-xr-x 1 root root 28 Nov 9 2020 egrep - -rwxr-xr-x 1 root root 39680 Sep 23 2020 false - -rwxr-xr-x 1 root root 28 Nov 9 2020 fgrep - -rwxr-xr-x 1 root root 69032 Jul 28 2021 findmnt - -rwsr-xr-x 1 root root 34896 Feb 26 2021 fusermount - -rwxr-xr-x 1 root root 203072 Nov 9 2020 grep - -rwxr-xr-x 2 root root 2346 Mar 2 2021 gunzip - -rwxr-xr-x 1 root root 6376 Mar 2 2021 gzexe - -rwxr-xr-x 1 root root 98048 Mar 2 2021 gzip - -rwxr-xr-x 1 root root 22600 Nov 6 2019 hostname - -rwxr-xr-x 1 root root 72840 Sep 23 2020 ln - -rwxr-xr-x 1 root root 56952 Feb 7 2020 login - -rwxr-xr-x 1 root root 147176 Sep 23 2020 ls - -rwxr-xr-x 1 root root 149736 Jul 28 2021 lsblk - -rwxr-xr-x 1 root root 85184 Sep 23 2020 mkdir - -rwxr-xr-x 1 root root 76896 Sep 23 2020 mknod - -rwxr-xr-x 1 root root 48064 Sep 23 2020 mktemp - -rwxr-xr-x 1 root root 59632 Jul 28 2021 more - -rwsr-xr-x 1 root root 55528 Jul 28 2021 mount - -rwxr-xr-x 1 root root 18664 Jul 28 2021 mountpoint - -rwxr-xr-x 1 root root 147080 Sep 23 2020 mv - lrwxrwxrwx 1 root root 8 Nov 6 2019 nisdomainname -> hostname - lrwxrwxrwx 1 root root 14 Apr 18 2021 pidof -> /sbin/killall5 - -rwxr-xr-x 1 root root 43872 Sep 23 2020 pwd - lrwxrwxrwx 1 root root 4 Aug 4 2021 rbash -> bash - -rwxr-xr-x 1 root root 52032 Sep 23 2020 readlink - -rwxr-xr-x 1 root root 72704 Sep 23 2020 rm - -rwxr-xr-x 1 root root 52032 Sep 23 2020 rmdir - -rwxr-xr-x 1 root root 27472 Sep 27 2020 run-parts - -rwxr-xr-x 1 root root 122224 Dec 22 2018 sed - lrwxrwxrwx 1 root root 4 Feb 6 21:25 sh -> dash - -rwxr-xr-x 1 root root 43808 Sep 23 2020 sleep - -rwxr-xr-x 1 root root 84928 Sep 23 2020 stty - -rwsr-xr-x 1 root root 71912 Jul 28 2021 su - -rwxr-xr-x 1 root root 39744 Sep 23 2020 sync - -rwxr-xr-x 1 root root 531928 Feb 16 2021 tar - -rwxr-xr-x 1 root root 14456 Sep 27 2020 tempfile - -rwxr-xr-x 1 root root 101408 Sep 23 2020 touch - -rwxr-xr-x 1 root root 39680 Sep 23 2020 true - -rwxr-xr-x 1 root root 14328 Feb 26 2021 ulockmgr_server - -rwsr-xr-x 1 root root 35040 Jul 28 2021 umount - -rwxr-xr-x 1 root root 39744 Sep 23 2020 uname - -rwxr-xr-x 2 root root 2346 Mar 2 2021 uncompress - -rwxr-xr-x 1 root root 147176 Sep 23 2020 vdir - -rwxr-xr-x 1 root root 63744 Jul 28 2021 wdctl - lrwxrwxrwx 1 root root 8 Nov 6 2019 ypdomainname -> hostname - -rwxr-xr-x 1 root root 1984 Mar 2 2021 zcat - -rwxr-xr-x 1 root root 1678 Mar 2 2021 zcmp - -rwxr-xr-x 1 root root 5880 Mar 2 2021 zdiff - -rwxr-xr-x 1 root root 29 Mar 2 2021 zegrep - -rwxr-xr-x 1 root root 29 Mar 2 2021 zfgrep - -rwxr-xr-x 1 root root 2081 Mar 2 2021 zforce - -rwxr-xr-x 1 root root 7585 Mar 2 2021 zgrep - -rwxr-xr-x 1 root root 2206 Mar 2 2021 zless - -rwxr-xr-x 1 root root 1842 Mar 2 2021 zmore - -rwxr-xr-x 1 root root 4553 Mar 2 2021 znew -I: user script /srv/workspace/pbuilder/379961/tmp/hooks/D02_print_environment finished + -rwxr-xr-x 1 root root 1234376 Aug 5 2021 bash + -rwxr-xr-x 3 root root 38984 Jul 21 2020 bunzip2 + -rwxr-xr-x 3 root root 38984 Jul 21 2020 bzcat + lrwxrwxrwx 1 root root 6 Jul 21 2020 bzcmp -> bzdiff + -rwxr-xr-x 1 root root 2225 Jul 21 2020 bzdiff + lrwxrwxrwx 1 root root 6 Jul 21 2020 bzegrep -> bzgrep + -rwxr-xr-x 1 root root 4877 Sep 5 2019 bzexe + lrwxrwxrwx 1 root root 6 Jul 21 2020 bzfgrep -> bzgrep + -rwxr-xr-x 1 root root 3775 Jul 21 2020 bzgrep + -rwxr-xr-x 3 root root 38984 Jul 21 2020 bzip2 + -rwxr-xr-x 1 root root 18424 Jul 21 2020 bzip2recover + lrwxrwxrwx 1 root root 6 Jul 21 2020 bzless -> bzmore + -rwxr-xr-x 1 root root 1297 Jul 21 2020 bzmore + -rwxr-xr-x 1 root root 43936 Sep 24 2020 cat + -rwxr-xr-x 1 root root 72672 Sep 24 2020 chgrp + -rwxr-xr-x 1 root root 64448 Sep 24 2020 chmod + -rwxr-xr-x 1 root root 72672 Sep 24 2020 chown + -rwxr-xr-x 1 root root 151168 Sep 24 2020 cp + -rwxr-xr-x 1 root root 125560 Dec 11 2020 dash + -rwxr-xr-x 1 root root 113664 Sep 24 2020 date + -rwxr-xr-x 1 root root 80968 Sep 24 2020 dd + -rwxr-xr-x 1 root root 93936 Sep 24 2020 df + -rwxr-xr-x 1 root root 147176 Sep 24 2020 dir + -rwxr-xr-x 1 root root 84440 Jul 29 2021 dmesg + lrwxrwxrwx 1 root root 8 Nov 8 2019 dnsdomainname -> hostname + lrwxrwxrwx 1 root root 8 Nov 8 2019 domainname -> hostname + -rwxr-xr-x 1 root root 39712 Sep 24 2020 echo + -rwxr-xr-x 1 root root 28 Nov 10 2020 egrep + -rwxr-xr-x 1 root root 39680 Sep 24 2020 false + -rwxr-xr-x 1 root root 28 Nov 10 2020 fgrep + -rwxr-xr-x 1 root root 69032 Jul 29 2021 findmnt + -rwsr-xr-x 1 root root 34896 Feb 27 2021 fusermount + -rwxr-xr-x 1 root root 203072 Nov 10 2020 grep + -rwxr-xr-x 2 root root 2346 Mar 3 2021 gunzip + -rwxr-xr-x 1 root root 6376 Mar 3 2021 gzexe + -rwxr-xr-x 1 root root 98048 Mar 3 2021 gzip + -rwxr-xr-x 1 root root 22600 Nov 8 2019 hostname + -rwxr-xr-x 1 root root 72840 Sep 24 2020 ln + -rwxr-xr-x 1 root root 56952 Feb 8 2020 login + -rwxr-xr-x 1 root root 147176 Sep 24 2020 ls + -rwxr-xr-x 1 root root 149736 Jul 29 2021 lsblk + -rwxr-xr-x 1 root root 85184 Sep 24 2020 mkdir + -rwxr-xr-x 1 root root 76896 Sep 24 2020 mknod + -rwxr-xr-x 1 root root 48064 Sep 24 2020 mktemp + -rwxr-xr-x 1 root root 59632 Jul 29 2021 more + -rwsr-xr-x 1 root root 55528 Jul 29 2021 mount + -rwxr-xr-x 1 root root 18664 Jul 29 2021 mountpoint + -rwxr-xr-x 1 root root 147080 Sep 24 2020 mv + lrwxrwxrwx 1 root root 8 Nov 8 2019 nisdomainname -> hostname + lrwxrwxrwx 1 root root 14 Apr 19 2021 pidof -> /sbin/killall5 + -rwxr-xr-x 1 root root 43872 Sep 24 2020 pwd + lrwxrwxrwx 1 root root 4 Aug 5 2021 rbash -> bash + -rwxr-xr-x 1 root root 52032 Sep 24 2020 readlink + -rwxr-xr-x 1 root root 72704 Sep 24 2020 rm + -rwxr-xr-x 1 root root 52032 Sep 24 2020 rmdir + -rwxr-xr-x 1 root root 27472 Sep 28 2020 run-parts + -rwxr-xr-x 1 root root 122224 Dec 23 2018 sed + lrwxrwxrwx 1 root root 4 Mar 16 09:50 sh -> bash + lrwxrwxrwx 1 root root 4 Mar 13 05:46 sh.distrib -> dash + -rwxr-xr-x 1 root root 43808 Sep 24 2020 sleep + -rwxr-xr-x 1 root root 84928 Sep 24 2020 stty + -rwsr-xr-x 1 root root 71912 Jul 29 2021 su + -rwxr-xr-x 1 root root 39744 Sep 24 2020 sync + -rwxr-xr-x 1 root root 531928 Feb 17 2021 tar + -rwxr-xr-x 1 root root 14456 Sep 28 2020 tempfile + -rwxr-xr-x 1 root root 101408 Sep 24 2020 touch + -rwxr-xr-x 1 root root 39680 Sep 24 2020 true + -rwxr-xr-x 1 root root 14328 Feb 27 2021 ulockmgr_server + -rwsr-xr-x 1 root root 35040 Jul 29 2021 umount + -rwxr-xr-x 1 root root 39744 Sep 24 2020 uname + -rwxr-xr-x 2 root root 2346 Mar 3 2021 uncompress + -rwxr-xr-x 1 root root 147176 Sep 24 2020 vdir + -rwxr-xr-x 1 root root 63744 Jul 29 2021 wdctl + lrwxrwxrwx 1 root root 8 Nov 8 2019 ypdomainname -> hostname + -rwxr-xr-x 1 root root 1984 Mar 3 2021 zcat + -rwxr-xr-x 1 root root 1678 Mar 3 2021 zcmp + -rwxr-xr-x 1 root root 5880 Mar 3 2021 zdiff + -rwxr-xr-x 1 root root 29 Mar 3 2021 zegrep + -rwxr-xr-x 1 root root 29 Mar 3 2021 zfgrep + -rwxr-xr-x 1 root root 2081 Mar 3 2021 zforce + -rwxr-xr-x 1 root root 7585 Mar 3 2021 zgrep + -rwxr-xr-x 1 root root 2206 Mar 3 2021 zless + -rwxr-xr-x 1 root root 1842 Mar 3 2021 zmore + -rwxr-xr-x 1 root root 4553 Mar 3 2021 znew +I: user script /srv/workspace/pbuilder/3443830/tmp/hooks/D02_print_environment finished -> Attempting to satisfy build-dependencies -> Creating pbuilder-satisfydepends-dummy package Package: pbuilder-satisfydepends-dummy @@ -419,7 +453,8 @@ Building tag database... -> Finished parsing the build-deps I: Building the package -I: Running cd /build/pads-1.2/ && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games" HOME="/nonexistent/first-build" dpkg-buildpackage -us -uc -b && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games" HOME="/nonexistent/first-build" dpkg-genchanges -S > ../pads_1.2-12_source.changes +hostname: Name or service not known +I: Running cd /build/pads-1.2/ && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/i/capture/the/path" HOME="/nonexistent/second-build" dpkg-buildpackage -us -uc -b && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/i/capture/the/path" HOME="/nonexistent/second-build" dpkg-genchanges -S > ../pads_1.2-12_source.changes dpkg-buildpackage: info: source package pads dpkg-buildpackage: info: source version 1.2-12 dpkg-buildpackage: info: source distribution unstable @@ -521,7 +556,7 @@ config.status: executing depfiles commands make[1]: Leaving directory '/build/pads-1.2' dh_auto_build - make -j15 + make -j16 make[1]: Entering directory '/build/pads-1.2' make all-recursive make[2]: Entering directory '/build/pads-1.2' @@ -607,38 +642,26 @@ /usr/include/stdio.h:246:44: note: expected 'const char * __restrict__' but argument is of type 'unsigned char *' 246 | extern FILE *fopen (const char *__restrict __filename, | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~ -output-fifo.c: In function 'print_arp_asset_fifo': -output-fifo.c:164:55: warning: pointer targets in passing argument 1 of 'hex2mac' differ in signedness [-Wpointer-sign] - 164 | (char *)rec->mac_resolved, hex2mac(rec->mac_addr), rec->discovered); - | ~~~^~~~~~~~~~ - | | - | char * -In file included from ../../src/mac-resolution.h:40, - from ../../src/storage.h:38, - from output.h:46, - from output-fifo.h:48, - from output-fifo.c:28: -../../src/util.h:60:36: note: expected 'const unsigned char *' but argument is of type 'char *' - 60 | char *hex2mac(unsigned const char *mac); - | ~~~~~~~~~~~~~~~~~~~~~^~~ -output-fifo.c:167:28: warning: pointer targets in passing argument 1 of 'hex2mac' differ in signedness [-Wpointer-sign] - 167 | hex2mac(rec->mac_addr), rec->discovered); - | ~~~^~~~~~~~~~ - | | - | char * -In file included from ../../src/mac-resolution.h:40, - from ../../src/storage.h:38, - from output.h:46, - from output-fifo.h:48, - from output-fifo.c:28: -../../src/util.h:60:36: note: expected 'const unsigned char *' but argument is of type 'char *' - 60 | char *hex2mac(unsigned const char *mac); - | ~~~~~~~~~~~~~~~~~~~~~^~~ -output.c: In function 'print_arp_asset': -output.c:210:4: warning: 'rec' may be used uninitialized in this function [-Wmaybe-uninitialized] - 210 | (*head->plugin->print_arp)(rec); - | ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +In file included from ../../src/global.h:75, + from output.h:45, + from output-csv.h:47, + from output-csv.c:27: +output-csv.c: In function 'init_output_csv': output-screen.c: In function 'print_arp_asset_screen': +../../lib/bstring/bstrlib.h:131:97: warning: pointer targets in passing argument 1 of 'fopen' differ in signedness [-Wpointer-sign] + 131 | #define bdataofse(b, o, e) (((b) == (void *)0 || (b)->data == (void*)0) ? (unsigned char *)(e) : ((b)->data) + (o)) + | ^ + | | + | unsigned char * +../../lib/bstring/bstrlib.h:132:30: note: in expansion of macro 'bdataofse' + 132 | #define bdataofs(b, o) (bdataofse ((b), (o), (void *)0)) + | ^~~~~~~~~ +../../lib/bstring/bstrlib.h:134:30: note: in expansion of macro 'bdataofs' + 134 | #define bdata(b) (bdataofs (b, 0)) + | ^~~~~~~~ +output-csv.c:86:21: note: in expansion of macro 'bdata' + 86 | if ((fp = fopen(bdata(output_csv_conf.filename), "r")) == NULL) { + | ^~~~~ output-screen.c:117:39: warning: pointer targets in passing argument 1 of 'hex2mac' differ in signedness [-Wpointer-sign] 117 | inet_ntoa(rec->ip_addr), hex2mac(rec->mac_addr), bdata(rec->mac_resolved)); | ~~~^~~~~~~~~~ @@ -652,6 +675,17 @@ ../../src/util.h:60:36: note: expected 'const unsigned char *' but argument is of type 'char *' 60 | char *hex2mac(unsigned const char *mac); | ~~~~~~~~~~~~~~~~~~~~~^~~ +In file included from output-csv.h:43, + from output-csv.c:27: +/usr/include/stdio.h:246:44: note: expected 'const char * __restrict__' but argument is of type 'unsigned char *' + 246 | extern FILE *fopen (const char *__restrict __filename, + | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~ +output-fifo.c: In function 'print_arp_asset_fifo': +output-fifo.c:164:55: warning: pointer targets in passing argument 1 of 'hex2mac' differ in signedness [-Wpointer-sign] + 164 | (char *)rec->mac_resolved, hex2mac(rec->mac_addr), rec->discovered); + | ~~~^~~~~~~~~~ + | | + | char * output-screen.c:120:39: warning: pointer targets in passing argument 1 of 'hex2mac' differ in signedness [-Wpointer-sign] 120 | inet_ntoa(rec->ip_addr), hex2mac(rec->mac_addr)); | ~~~^~~~~~~~~~ @@ -660,6 +694,14 @@ In file included from ../../src/mac-resolution.h:40, from ../../src/storage.h:38, from output.h:46, + from output-fifo.h:48, + from output-fifo.c:28: +../../src/util.h:60:36: note: expected 'const unsigned char *' but argument is of type 'char *' + 60 | char *hex2mac(unsigned const char *mac); + | ~~~~~~~~~~~~~~~~~~~~~^~~ +In file included from ../../src/mac-resolution.h:40, + from ../../src/storage.h:38, + from output.h:46, from output-screen.h:46, from output-screen.c:27: ../../src/util.h:60:36: note: expected 'const unsigned char *' but argument is of type 'char *' @@ -669,30 +711,6 @@ from output.h:45, from output-csv.h:47, from output-csv.c:27: -output-csv.c: In function 'init_output_csv': -../../lib/bstring/bstrlib.h:131:97: warning: pointer targets in passing argument 1 of 'fopen' differ in signedness [-Wpointer-sign] - 131 | #define bdataofse(b, o, e) (((b) == (void *)0 || (b)->data == (void*)0) ? (unsigned char *)(e) : ((b)->data) + (o)) - | ^ - | | - | unsigned char * -../../lib/bstring/bstrlib.h:132:30: note: in expansion of macro 'bdataofse' - 132 | #define bdataofs(b, o) (bdataofse ((b), (o), (void *)0)) - | ^~~~~~~~~ -../../lib/bstring/bstrlib.h:134:30: note: in expansion of macro 'bdataofs' - 134 | #define bdata(b) (bdataofs (b, 0)) - | ^~~~~~~~ -output-csv.c:86:21: note: in expansion of macro 'bdata' - 86 | if ((fp = fopen(bdata(output_csv_conf.filename), "r")) == NULL) { - | ^~~~~ -In file included from output-csv.h:43, - from output-csv.c:27: -/usr/include/stdio.h:246:44: note: expected 'const char * __restrict__' but argument is of type 'unsigned char *' - 246 | extern FILE *fopen (const char *__restrict __filename, - | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~ -In file included from ../../src/global.h:75, - from output.h:45, - from output-csv.h:47, - from output-csv.c:27: ../../lib/bstring/bstrlib.h:131:97: warning: pointer targets in passing argument 1 of 'fopen' differ in signedness [-Wpointer-sign] 131 | #define bdataofse(b, o, e) (((b) == (void *)0 || (b)->data == (void*)0) ? (unsigned char *)(e) : ((b)->data) + (o)) | ^ @@ -707,11 +725,24 @@ output-csv.c:89:43: note: in expansion of macro 'bdata' 89 | if ((output_csv_conf.file = fopen(bdata(output_csv_conf.filename), "w")) != NULL) { | ^~~~~ +output-fifo.c:167:28: warning: pointer targets in passing argument 1 of 'hex2mac' differ in signedness [-Wpointer-sign] + 167 | hex2mac(rec->mac_addr), rec->discovered); + | ~~~^~~~~~~~~~ + | | + | char * In file included from output-csv.h:43, from output-csv.c:27: /usr/include/stdio.h:246:44: note: expected 'const char * __restrict__' but argument is of type 'unsigned char *' 246 | extern FILE *fopen (const char *__restrict __filename, | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~ +In file included from ../../src/mac-resolution.h:40, + from ../../src/storage.h:38, + from output.h:46, + from output-fifo.h:48, + from output-fifo.c:28: +../../src/util.h:60:36: note: expected 'const unsigned char *' but argument is of type 'char *' + 60 | char *hex2mac(unsigned const char *mac); + | ~~~~~~~~~~~~~~~~~~~~~^~~ In file included from ../../src/global.h:75, from output.h:45, from output-csv.h:47, @@ -925,6 +956,10 @@ ../../src/util.h:60:36: note: expected 'const unsigned char *' but argument is of type 'char *' 60 | char *hex2mac(unsigned const char *mac); | ~~~~~~~~~~~~~~~~~~~~~^~~ +output.c: In function 'print_arp_asset': +output.c:210:4: warning: 'rec' may be used uninitialized in this function [-Wmaybe-uninitialized] + 210 | (*head->plugin->print_arp)(rec); + | ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ rm -f liboutput.a ar cru liboutput.a output.o output-screen.o output-csv.o output-fifo.o ar: `u' modifier ignored since `D' is the default (see `U') @@ -937,6 +972,7 @@ gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../lib -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/build/pads-1.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -g -std=gnu89 -c -o packet.o packet.c gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../lib -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/build/pads-1.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -g -std=gnu89 -c -o monnet.o monnet.c gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../lib -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/build/pads-1.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -g -std=gnu89 -c -o mac-resolution.o mac-resolution.c +gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../lib -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/build/pads-1.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -g -std=gnu89 -c -o configuration.o configuration.c In file included from /usr/include/netinet/in.h:21, from global.h:69, from packet.h:44, @@ -944,7 +980,6 @@ /usr/include/features.h:187:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp] 187 | # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" | ^~~~~~~ -gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../lib -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/build/pads-1.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -g -std=gnu89 -c -o configuration.o configuration.c gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../lib -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/build/pads-1.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -g -std=gnu89 -c -o util.o util.c cat ./pads-report.pl >> pads-report chmod +x pads-report @@ -973,6 +1008,10 @@ pads.c:212:45: note: in expansion of macro 'bdata' 212 | if (!(gc.handle = pcap_open_offline(bdata(gc.pcap_file), errbuf))) { | ^~~~~ +In file included from global.h:75, + from identification.h:35, + from identification.c:28: +identification.c: In function 'init_identification': In file included from /usr/include/pcap.h:43, from global.h:72, from pads.h:50, @@ -980,6 +1019,25 @@ /usr/include/pcap/pcap.h:527:36: note: expected 'const char *' but argument is of type 'unsigned char *' 527 | PCAP_API pcap_t *pcap_open_offline(const char *, char *); | ^~~~~~~~~~~~ +../lib/bstring/bstrlib.h:131:97: warning: pointer targets in passing argument 1 of 'fopen' differ in signedness [-Wpointer-sign] + 131 | #define bdataofse(b, o, e) (((b) == (void *)0 || (b)->data == (void*)0) ? (unsigned char *)(e) : ((b)->data) + (o)) + | ^ + | | + | unsigned char * +../lib/bstring/bstrlib.h:132:30: note: in expansion of macro 'bdataofse' + 132 | #define bdataofs(b, o) (bdataofse ((b), (o), (void *)0)) + | ^~~~~~~~~ +../lib/bstring/bstrlib.h:134:30: note: in expansion of macro 'bdataofs' + 134 | #define bdata(b) (bdataofs (b, 0)) + | ^~~~~~~~ +identification.c:60:21: note: in expansion of macro 'bdata' + 60 | if ((fp = fopen(bdata(filename), "r")) == NULL) { + | ^~~~~ +In file included from identification.h:32, + from identification.c:28: +/usr/include/stdio.h:246:44: note: expected 'const char * __restrict__' but argument is of type 'unsigned char *' + 246 | extern FILE *fopen (const char *__restrict __filename, + | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~ pads.c:228:13: warning: 'pcap_lookupdev' is deprecated: use 'pcap_findalldevs' and use the first device [-Wdeprecated-declarations] 228 | if (!(gc.dev = pcap_lookupdev(errbuf))) | ^~ @@ -990,6 +1048,16 @@ /usr/include/pcap/pcap.h:394:16: note: declared here 394 | PCAP_API char *pcap_lookupdev(char *) | ^~~~~~~~~~~~~~ +monnet.c: In function 'parse_networks': +monnet.c:83:2: warning: value computed is not used [-Wunused-value] + 83 | *cmdline++; + | ^~~~~~~~~~ +storage.c: In function 'print_database': +storage.c:485:14: warning: pointer targets in passing argument 1 of 'hex2mac' differ in signedness [-Wpointer-sign] + 485 | hex2mac(arp->mac_addr), arp->discovered); + | ~~~^~~~~~~~~~ + | | + | char * In file included from global.h:75, from pads.h:50, from pads.c:28: @@ -1007,6 +1075,12 @@ pads.c:270:53: note: in expansion of macro 'bdata' 270 | if (!(gc.dumper = pcap_dump_open(gc.handle, bdata(gc.dump_file)))) | ^~~~~ +In file included from mac-resolution.h:40, + from storage.h:38, + from storage.c:27: +util.h:60:36: note: expected 'const unsigned char *' but argument is of type 'char *' + 60 | char *hex2mac(unsigned const char *mac); + | ~~~~~~~~~~~~~~~~~~~~~^~~ In file included from /usr/include/pcap.h:43, from global.h:72, from pads.h:50, @@ -1015,6 +1089,30 @@ 695 | PCAP_API pcap_dumper_t *pcap_dump_open(pcap_t *, const char *); | ^~~~~~~~~~~~ In file included from global.h:75, + from identification.h:35, + from identification.c:28: +identification.c: In function 'parse_raw_signature': +../lib/bstring/bstrlib.h:131:97: warning: pointer targets in passing argument 1 of 'pcre_compile' differ in signedness [-Wpointer-sign] + 131 | #define bdataofse(b, o, e) (((b) == (void *)0 || (b)->data == (void*)0) ? (unsigned char *)(e) : ((b)->data) + (o)) + | ^ + | | + | unsigned char * +../lib/bstring/bstrlib.h:132:30: note: in expansion of macro 'bdataofse' + 132 | #define bdataofs(b, o) (bdataofse ((b), (o), (void *)0)) + | ^~~~~~~~~ +../lib/bstring/bstrlib.h:134:30: note: in expansion of macro 'bdataofs' + 134 | #define bdata(b) (bdataofs (b, 0)) + | ^~~~~~~~ +identification.c:148:45: note: in expansion of macro 'bdata' + 148 | if ((sig->regex = pcre_compile (bdata(pcre_string), 0, &err, &erroffset, NULL)) == NULL) { + | ^~~~~ +In file included from global.h:73, + from identification.h:35, + from identification.c:28: +/usr/include/pcre.h:540:34: note: expected 'const char *' but argument is of type 'unsigned char *' + 540 | PCRE_EXP_DECL pcre *pcre_compile(const char *, int, const char **, int *, + | ^~~~~~~~~~~~ +In file included from global.h:75, from pads.h:50, from pads.c:28: pads.c: In function 'end_pads': @@ -1041,6 +1139,73 @@ 325 | if ((unlink(bdata(gc.pid_file))) != 0) | ^~~~~~ In file included from global.h:75, + from identification.h:35, + from identification.c:28: +identification.c: In function 'get_app_name': +../lib/bstring/bstrlib.h:131:97: warning: pointer targets in passing argument 2 of 'strlcpy' differ in signedness [-Wpointer-sign] + 131 | #define bdataofse(b, o, e) (((b) == (void *)0 || (b)->data == (void*)0) ? (unsigned char *)(e) : ((b)->data) + (o)) + | ^ + | | + | unsigned char * +../lib/bstring/bstrlib.h:132:30: note: in expansion of macro 'bdataofse' + 132 | #define bdataofs(b, o) (bdataofse ((b), (o), (void *)0)) + | ^~~~~~~~~ +../lib/bstring/bstrlib.h:134:30: note: in expansion of macro 'bdataofs' + 134 | #define bdata(b) (bdataofs (b, 0)) + | ^~~~~~~~ +identification.c:314:22: note: in expansion of macro 'bdata' + 314 | strlcpy(app, bdata(sig->title.app), MAX_APP); + | ^~~~~ +In file included from identification.h:36, + from identification.c:28: +util.h:53:39: note: expected 'const char *' but argument is of type 'unsigned char *' + 53 | size_t strlcpy(char *dst, const char *src, size_t size); + | ~~~~~~~~~~~~^~~ +In file included from global.h:75, + from identification.h:35, + from identification.c:28: +../lib/bstring/bstrlib.h:131:97: warning: pointer targets in passing argument 2 of 'strlcat' differ in signedness [-Wpointer-sign] + 131 | #define bdataofse(b, o, e) (((b) == (void *)0 || (b)->data == (void*)0) ? (unsigned char *)(e) : ((b)->data) + (o)) + | ^ + | | + | unsigned char * +../lib/bstring/bstrlib.h:132:30: note: in expansion of macro 'bdataofse' + 132 | #define bdataofs(b, o) (bdataofse ((b), (o), (void *)0)) + | ^~~~~~~~~ +../lib/bstring/bstrlib.h:134:30: note: in expansion of macro 'bdataofs' + 134 | #define bdata(b) (bdataofs (b, 0)) + | ^~~~~~~~ +identification.c:319:26: note: in expansion of macro 'bdata' + 319 | strlcat(app, bdata(sig->title.ver), MAX_VER); + | ^~~~~ +In file included from identification.h:36, + from identification.c:28: +util.h:56:39: note: expected 'const char *' but argument is of type 'unsigned char *' + 56 | size_t strlcat(char *dst, const char *src, size_t len); + | ~~~~~~~~~~~~^~~ +In file included from global.h:75, + from identification.h:35, + from identification.c:28: +../lib/bstring/bstrlib.h:131:97: warning: pointer targets in passing argument 2 of 'strlcat' differ in signedness [-Wpointer-sign] + 131 | #define bdataofse(b, o, e) (((b) == (void *)0 || (b)->data == (void*)0) ? (unsigned char *)(e) : ((b)->data) + (o)) + | ^ + | | + | unsigned char * +../lib/bstring/bstrlib.h:132:30: note: in expansion of macro 'bdataofse' + 132 | #define bdataofs(b, o) (bdataofse ((b), (o), (void *)0)) + | ^~~~~~~~~ +../lib/bstring/bstrlib.h:134:30: note: in expansion of macro 'bdataofs' + 134 | #define bdata(b) (bdataofs (b, 0)) + | ^~~~~~~~ +identification.c:325:26: note: in expansion of macro 'bdata' + 325 | strlcat(app, bdata(sig->title.misc), MAX_MISC); + | ^~~~~ +In file included from identification.h:36, + from identification.c:28: +util.h:56:39: note: expected 'const char *' but argument is of type 'unsigned char *' + 56 | size_t strlcat(char *dst, const char *src, size_t len); + | ~~~~~~~~~~~~^~~ +In file included from global.h:75, from mac-resolution.h:39, from mac-resolution.c:34: mac-resolution.c: In function 'init_mac_resolution': @@ -1126,132 +1291,6 @@ 225 | payload = (u_char *)(packet + sizeof(struct tcphdr) + len); | ^ In file included from global.h:75, - from identification.h:35, - from identification.c:28: -identification.c: In function 'init_identification': -../lib/bstring/bstrlib.h:131:97: warning: pointer targets in passing argument 1 of 'fopen' differ in signedness [-Wpointer-sign] - 131 | #define bdataofse(b, o, e) (((b) == (void *)0 || (b)->data == (void*)0) ? (unsigned char *)(e) : ((b)->data) + (o)) - | ^ - | | - | unsigned char * -../lib/bstring/bstrlib.h:132:30: note: in expansion of macro 'bdataofse' - 132 | #define bdataofs(b, o) (bdataofse ((b), (o), (void *)0)) - | ^~~~~~~~~ -../lib/bstring/bstrlib.h:134:30: note: in expansion of macro 'bdataofs' - 134 | #define bdata(b) (bdataofs (b, 0)) - | ^~~~~~~~ -identification.c:60:21: note: in expansion of macro 'bdata' - 60 | if ((fp = fopen(bdata(filename), "r")) == NULL) { - | ^~~~~ -In file included from identification.h:32, - from identification.c:28: -/usr/include/stdio.h:246:44: note: expected 'const char * __restrict__' but argument is of type 'unsigned char *' - 246 | extern FILE *fopen (const char *__restrict __filename, - | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~ -In file included from global.h:75, - from identification.h:35, - from identification.c:28: -identification.c: In function 'parse_raw_signature': -../lib/bstring/bstrlib.h:131:97: warning: pointer targets in passing argument 1 of 'pcre_compile' differ in signedness [-Wpointer-sign] - 131 | #define bdataofse(b, o, e) (((b) == (void *)0 || (b)->data == (void*)0) ? (unsigned char *)(e) : ((b)->data) + (o)) - | ^ - | | - | unsigned char * -../lib/bstring/bstrlib.h:132:30: note: in expansion of macro 'bdataofse' - 132 | #define bdataofs(b, o) (bdataofse ((b), (o), (void *)0)) - | ^~~~~~~~~ -../lib/bstring/bstrlib.h:134:30: note: in expansion of macro 'bdataofs' - 134 | #define bdata(b) (bdataofs (b, 0)) - | ^~~~~~~~ -identification.c:148:45: note: in expansion of macro 'bdata' - 148 | if ((sig->regex = pcre_compile (bdata(pcre_string), 0, &err, &erroffset, NULL)) == NULL) { - | ^~~~~ -In file included from global.h:73, - from identification.h:35, - from identification.c:28: -/usr/include/pcre.h:540:34: note: expected 'const char *' but argument is of type 'unsigned char *' - 540 | PCRE_EXP_DECL pcre *pcre_compile(const char *, int, const char **, int *, - | ^~~~~~~~~~~~ -In file included from global.h:75, - from identification.h:35, - from identification.c:28: -identification.c: In function 'get_app_name': -../lib/bstring/bstrlib.h:131:97: warning: pointer targets in passing argument 2 of 'strlcpy' differ in signedness [-Wpointer-sign] - 131 | #define bdataofse(b, o, e) (((b) == (void *)0 || (b)->data == (void*)0) ? (unsigned char *)(e) : ((b)->data) + (o)) - | ^ - | | - | unsigned char * -../lib/bstring/bstrlib.h:132:30: note: in expansion of macro 'bdataofse' - 132 | #define bdataofs(b, o) (bdataofse ((b), (o), (void *)0)) - | ^~~~~~~~~ -../lib/bstring/bstrlib.h:134:30: note: in expansion of macro 'bdataofs' - 134 | #define bdata(b) (bdataofs (b, 0)) - | ^~~~~~~~ -identification.c:314:22: note: in expansion of macro 'bdata' - 314 | strlcpy(app, bdata(sig->title.app), MAX_APP); - | ^~~~~ -In file included from identification.h:36, - from identification.c:28: -util.h:53:39: note: expected 'const char *' but argument is of type 'unsigned char *' - 53 | size_t strlcpy(char *dst, const char *src, size_t size); - | ~~~~~~~~~~~~^~~ -In file included from global.h:75, - from identification.h:35, - from identification.c:28: -../lib/bstring/bstrlib.h:131:97: warning: pointer targets in passing argument 2 of 'strlcat' differ in signedness [-Wpointer-sign] - 131 | #define bdataofse(b, o, e) (((b) == (void *)0 || (b)->data == (void*)0) ? (unsigned char *)(e) : ((b)->data) + (o)) - | ^ - | | - | unsigned char * -../lib/bstring/bstrlib.h:132:30: note: in expansion of macro 'bdataofse' - 132 | #define bdataofs(b, o) (bdataofse ((b), (o), (void *)0)) - | ^~~~~~~~~ -../lib/bstring/bstrlib.h:134:30: note: in expansion of macro 'bdataofs' - 134 | #define bdata(b) (bdataofs (b, 0)) - | ^~~~~~~~ -identification.c:319:26: note: in expansion of macro 'bdata' - 319 | strlcat(app, bdata(sig->title.ver), MAX_VER); - | ^~~~~ -In file included from identification.h:36, - from identification.c:28: -util.h:56:39: note: expected 'const char *' but argument is of type 'unsigned char *' - 56 | size_t strlcat(char *dst, const char *src, size_t len); - | ~~~~~~~~~~~~^~~ -In file included from global.h:75, - from identification.h:35, - from identification.c:28: -../lib/bstring/bstrlib.h:131:97: warning: pointer targets in passing argument 2 of 'strlcat' differ in signedness [-Wpointer-sign] - 131 | #define bdataofse(b, o, e) (((b) == (void *)0 || (b)->data == (void*)0) ? (unsigned char *)(e) : ((b)->data) + (o)) - | ^ - | | - | unsigned char * -../lib/bstring/bstrlib.h:132:30: note: in expansion of macro 'bdataofse' - 132 | #define bdataofs(b, o) (bdataofse ((b), (o), (void *)0)) - | ^~~~~~~~~ -../lib/bstring/bstrlib.h:134:30: note: in expansion of macro 'bdataofs' - 134 | #define bdata(b) (bdataofs (b, 0)) - | ^~~~~~~~ -identification.c:325:26: note: in expansion of macro 'bdata' - 325 | strlcat(app, bdata(sig->title.misc), MAX_MISC); - | ^~~~~ -In file included from identification.h:36, - from identification.c:28: -util.h:56:39: note: expected 'const char *' but argument is of type 'unsigned char *' - 56 | size_t strlcat(char *dst, const char *src, size_t len); - | ~~~~~~~~~~~~^~~ -storage.c: In function 'print_database': -storage.c:485:14: warning: pointer targets in passing argument 1 of 'hex2mac' differ in signedness [-Wpointer-sign] - 485 | hex2mac(arp->mac_addr), arp->discovered); - | ~~~^~~~~~~~~~ - | | - | char * -In file included from mac-resolution.h:40, - from storage.h:38, - from storage.c:27: -util.h:60:36: note: expected 'const unsigned char *' but argument is of type 'char *' - 60 | char *hex2mac(unsigned const char *mac); - | ~~~~~~~~~~~~~~~~~~~~~^~~ -In file included from global.h:75, from util.h:41, from util.c:28: util.c: In function 'init_pid_file': @@ -1347,10 +1386,10 @@ 119 | if ((chown(bdata(pid_file), this_user->pw_uid, this_group->gr_gid)) != 0) | ^~~~~ In file included from global.h:75, - from util.h:41, - from util.c:28: -util.c: In function 'drop_privs': -../lib/bstring/bstrlib.h:131:97: warning: pointer targets in passing argument 1 of 'getgrnam' differ in signedness [-Wpointer-sign] + from configuration.h:45, + from configuration.c:28: +configuration.c: In function 'init_configuration': +../lib/bstring/bstrlib.h:131:97: warning: pointer targets in passing argument 1 of 'fopen' differ in signedness [-Wpointer-sign] 131 | #define bdataofse(b, o, e) (((b) == (void *)0 || (b)->data == (void*)0) ? (unsigned char *)(e) : ((b)->data) + (o)) | ^ | | @@ -1361,18 +1400,19 @@ ../lib/bstring/bstrlib.h:134:30: note: in expansion of macro 'bdataofs' 134 | #define bdata(b) (bdataofs (b, 0)) | ^~~~~~~~ -util.c:366:32: note: in expansion of macro 'bdata' - 366 | if ((this_group = getgrnam(bdata(newgroup))) == NULL) - | ^~~~~ -In file included from util.h:37, - from util.c:28: -/usr/include/grp.h:107:44: note: expected 'const char *' but argument is of type 'unsigned char *' - 107 | extern struct group *getgrnam (const char *__name); - | ~~~~~~~~~~~~^~~~~~ +configuration.c:47:21: note: in expansion of macro 'bdata' + 47 | if ((fp = fopen(bdata(filename), "r")) == NULL) { + | ^~~~~ +In file included from configuration.h:44, + from configuration.c:28: +/usr/include/stdio.h:246:44: note: expected 'const char * __restrict__' but argument is of type 'unsigned char *' + 246 | extern FILE *fopen (const char *__restrict __filename, + | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~ In file included from global.h:75, from util.h:41, from util.c:28: -../lib/bstring/bstrlib.h:131:97: warning: pointer targets in passing argument 1 of 'getpwnam' differ in signedness [-Wpointer-sign] +util.c: In function 'drop_privs': +../lib/bstring/bstrlib.h:131:97: warning: pointer targets in passing argument 1 of 'getgrnam' differ in signedness [-Wpointer-sign] 131 | #define bdataofse(b, o, e) (((b) == (void *)0 || (b)->data == (void*)0) ? (unsigned char *)(e) : ((b)->data) + (o)) | ^ | | @@ -1383,44 +1423,14 @@ ../lib/bstring/bstrlib.h:134:30: note: in expansion of macro 'bdataofs' 134 | #define bdata(b) (bdataofs (b, 0)) | ^~~~~~~~ -util.c:369:31: note: in expansion of macro 'bdata' - 369 | if ((this_user = getpwnam(bdata(newuser))) == NULL) - | ^~~~~ -In file included from util.h:38, +util.c:366:32: note: in expansion of macro 'bdata' + 366 | if ((this_group = getgrnam(bdata(newgroup))) == NULL) + | ^~~~~ +In file included from util.h:37, from util.c:28: -/usr/include/pwd.h:116:45: note: expected 'const char *' but argument is of type 'unsigned char *' - 116 | extern struct passwd *getpwnam (const char *__name) __nonnull ((1)); - | ~~~~~~~~~~~~^~~~~~ -util.c:369:22: warning: null argument where non-null required (argument 1) [-Wnonnull] - 369 | if ((this_user = getpwnam(bdata(newuser))) == NULL) - | ^~~~~~~~ -monnet.c: In function 'parse_networks': -monnet.c:83:2: warning: value computed is not used [-Wunused-value] - 83 | *cmdline++; - | ^~~~~~~~~~ -In file included from global.h:75, - from configuration.h:45, - from configuration.c:28: -configuration.c: In function 'init_configuration': -../lib/bstring/bstrlib.h:131:97: warning: pointer targets in passing argument 1 of 'fopen' differ in signedness [-Wpointer-sign] - 131 | #define bdataofse(b, o, e) (((b) == (void *)0 || (b)->data == (void*)0) ? (unsigned char *)(e) : ((b)->data) + (o)) - | ^ - | | - | unsigned char * -../lib/bstring/bstrlib.h:132:30: note: in expansion of macro 'bdataofse' - 132 | #define bdataofs(b, o) (bdataofse ((b), (o), (void *)0)) - | ^~~~~~~~~ -../lib/bstring/bstrlib.h:134:30: note: in expansion of macro 'bdataofs' - 134 | #define bdata(b) (bdataofs (b, 0)) - | ^~~~~~~~ -configuration.c:47:21: note: in expansion of macro 'bdata' - 47 | if ((fp = fopen(bdata(filename), "r")) == NULL) { - | ^~~~~ -In file included from configuration.h:44, - from configuration.c:28: -/usr/include/stdio.h:246:44: note: expected 'const char * __restrict__' but argument is of type 'unsigned char *' - 246 | extern FILE *fopen (const char *__restrict __filename, - | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~ +/usr/include/grp.h:107:44: note: expected 'const char *' but argument is of type 'unsigned char *' + 107 | extern struct group *getgrnam (const char *__name); + | ~~~~~~~~~~~~^~~~~~ In file included from global.h:75, from configuration.h:45, from configuration.c:28: @@ -1446,6 +1456,31 @@ monnet.h:48:28: note: expected 'char *' but argument is of type 'unsigned char *' 48 | void parse_networks (char *cmdline); | ~~~~~~^~~~~~~ +In file included from global.h:75, + from util.h:41, + from util.c:28: +../lib/bstring/bstrlib.h:131:97: warning: pointer targets in passing argument 1 of 'getpwnam' differ in signedness [-Wpointer-sign] + 131 | #define bdataofse(b, o, e) (((b) == (void *)0 || (b)->data == (void*)0) ? (unsigned char *)(e) : ((b)->data) + (o)) + | ^ + | | + | unsigned char * +../lib/bstring/bstrlib.h:132:30: note: in expansion of macro 'bdataofse' + 132 | #define bdataofs(b, o) (bdataofse ((b), (o), (void *)0)) + | ^~~~~~~~~ +../lib/bstring/bstrlib.h:134:30: note: in expansion of macro 'bdataofs' + 134 | #define bdata(b) (bdataofs (b, 0)) + | ^~~~~~~~ +util.c:369:31: note: in expansion of macro 'bdata' + 369 | if ((this_user = getpwnam(bdata(newuser))) == NULL) + | ^~~~~ +In file included from util.h:38, + from util.c:28: +/usr/include/pwd.h:116:45: note: expected 'const char *' but argument is of type 'unsigned char *' + 116 | extern struct passwd *getpwnam (const char *__name) __nonnull ((1)); + | ~~~~~~~~~~~~^~~~~~ +util.c:369:22: warning: null argument where non-null required (argument 1) [-Wnonnull] + 369 | if ((this_user = getpwnam(bdata(newuser))) == NULL) + | ^~~~~~~~ identification.c: In function 'parse_raw_signature': identification.c:130:14: warning: 'title' may be used uninitialized in this function [-Wmaybe-uninitialized] 130 | if (title->qty < 3) @@ -1453,14 +1488,14 @@ identification.c:170:8: warning: 'pcre_string' may be used uninitialized in this function [-Wmaybe-uninitialized] 170 | if (pcre_string != NULL) | ^ -util.c: In function 'strlcat': -util.c:328:9: warning: 'tocopy' is used uninitialized in this function [-Wuninitialized] - 328 | while (tocopy-- && *dstptr) dstptr++; - | ^ storage.c: In function 'find_asset': storage.c:403:12: warning: 'rec' may be used uninitialized in this function [-Wmaybe-uninitialized] 403 | Asset *rec; | ^~~ +util.c: In function 'strlcat': +util.c:328:9: warning: 'tocopy' is used uninitialized in this function [-Wuninitialized] + 328 | while (tocopy-- && *dstptr) dstptr++; + | ^ gcc -g -O2 -fdebug-prefix-map=/build/pads-1.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -g -std=gnu89 -Wl,-z,relro -lpcre -o pads pads.o storage.o identification.o packet.o monnet.o mac-resolution.o configuration.o util.o ../lib/bstring/libbstring.a output/liboutput.a -lpcre -lpcap make[4]: Leaving directory '/build/pads-1.2/src' make[3]: Leaving directory '/build/pads-1.2/src' @@ -1469,7 +1504,7 @@ make[2]: Leaving directory '/build/pads-1.2' make[1]: Leaving directory '/build/pads-1.2' dh_auto_test - make -j15 check VERBOSE=1 + make -j16 check VERBOSE=1 make[1]: Entering directory '/build/pads-1.2' Making check in doc make[2]: Entering directory '/build/pads-1.2/doc' @@ -1508,7 +1543,7 @@ debian/rules override_dh_auto_install make[1]: Entering directory '/build/pads-1.2' dh_auto_install -- -C src - make -j15 install DESTDIR=/build/pads-1.2/debian/pads AM_UPDATE_INFO_DIR=no -C src + make -j16 install DESTDIR=/build/pads-1.2/debian/pads AM_UPDATE_INFO_DIR=no -C src make[2]: Entering directory '/build/pads-1.2/src' Making install in output make[3]: Entering directory '/build/pads-1.2/src/output' @@ -1522,13 +1557,13 @@ make[4]: Nothing to be done for 'install-data-am'. /bin/mkdir -p '/build/pads-1.2/debian/pads/usr/bin' /bin/mkdir -p '/build/pads-1.2/debian/pads/usr/bin' - /usr/bin/install -c pads-report '/build/pads-1.2/debian/pads/usr/bin' /usr/bin/install -c pads '/build/pads-1.2/debian/pads/usr/bin' + /usr/bin/install -c pads-report '/build/pads-1.2/debian/pads/usr/bin' make[4]: Leaving directory '/build/pads-1.2/src' make[3]: Leaving directory '/build/pads-1.2/src' make[2]: Leaving directory '/build/pads-1.2/src' dh_auto_install -- -C etc - make -j15 install DESTDIR=/build/pads-1.2/debian/pads AM_UPDATE_INFO_DIR=no -C etc + make -j16 install DESTDIR=/build/pads-1.2/debian/pads AM_UPDATE_INFO_DIR=no -C etc make[2]: Entering directory '/build/pads-1.2/etc' make[3]: Entering directory '/build/pads-1.2/etc' make[3]: Nothing to be done for 'install-data-am'. @@ -1566,12 +1601,14 @@ dpkg-buildpackage: info: binary-only upload (no source included) dpkg-genchanges: info: not including original source code in upload I: copying local configuration +I: user script /srv/workspace/pbuilder/3443830/tmp/hooks/B01_cleanup starting +I: user script /srv/workspace/pbuilder/3443830/tmp/hooks/B01_cleanup finished I: unmounting dev/ptmx filesystem I: unmounting dev/pts filesystem I: unmounting dev/shm filesystem I: unmounting proc filesystem I: unmounting sys filesystem I: cleaning the build env -I: removing directory /srv/workspace/pbuilder/379961 and its subdirectories -I: Current time: Thu Feb 10 01:26:58 -12 2022 -I: pbuilder-time-stamp: 1644499618 +I: removing directory /srv/workspace/pbuilder/3443830 and its subdirectories +I: Current time: Thu Mar 16 09:50:34 +14 2023 +I: pbuilder-time-stamp: 1678909834