Diff of the two buildlogs: -- --- b1/build.log 2024-05-13 19:32:33.132309589 +0000 +++ b2/build.log 2024-05-13 19:33:29.885895837 +0000 @@ -1,6 +1,6 @@ I: pbuilder: network access will be disabled during build -I: Current time: Sun Jun 15 13:54:50 -12 2025 -I: pbuilder-time-stamp: 1750038890 +I: Current time: Tue May 14 09:32:36 +14 2024 +I: pbuilder-time-stamp: 1715628756 I: Building the build Environment I: extracting base tarball [/var/cache/pbuilder/trixie-reproducible-base.tgz] I: copying local configuration @@ -26,54 +26,86 @@ dpkg-source: info: unpacking ksmbd-tools_3.5.2-2.debian.tar.xz I: Not using root during the build. I: Installing the build-deps -I: user script /srv/workspace/pbuilder/92801/tmp/hooks/D02_print_environment starting +I: user script /srv/workspace/pbuilder/61333/tmp/hooks/D01_modify_environment starting +debug: Running on ionos2-i386. +I: Changing host+domainname to test build reproducibility +I: Adding a custom variable just for the fun of it... +I: Changing /bin/sh to bash +'/bin/sh' -> '/bin/bash' +lrwxrwxrwx 1 root root 9 May 13 19:32 /bin/sh -> /bin/bash +I: Setting pbuilder2's login shell to /bin/bash +I: Setting pbuilder2's GECOS to second user,second room,second work-phone,second home-phone,second other +I: user script /srv/workspace/pbuilder/61333/tmp/hooks/D01_modify_environment finished +I: user script /srv/workspace/pbuilder/61333/tmp/hooks/D02_print_environment starting I: set - BUILDDIR='/build/reproducible-path' - BUILDUSERGECOS='first user,first room,first work-phone,first home-phone,first other' - BUILDUSERNAME='pbuilder1' - BUILD_ARCH='i386' - DEBIAN_FRONTEND='noninteractive' - DEB_BUILD_OPTIONS='buildinfo=+all reproducible=+all parallel=22 ' - DISTRIBUTION='trixie' - HOME='/root' - HOST_ARCH='i386' + BASH=/bin/sh + BASHOPTS=checkwinsize:cmdhist:complete_fullquote:extquote:force_fignore:globasciiranges:globskipdots:hostcomplete:interactive_comments:patsub_replacement:progcomp:promptvars:sourcepath + BASH_ALIASES=() + BASH_ARGC=() + BASH_ARGV=() + BASH_CMDS=() + BASH_LINENO=([0]="12" [1]="0") + BASH_LOADABLES_PATH=/usr/local/lib/bash:/usr/lib/bash:/opt/local/lib/bash:/usr/pkg/lib/bash:/opt/pkg/lib/bash:. + BASH_SOURCE=([0]="/tmp/hooks/D02_print_environment" [1]="/tmp/hooks/D02_print_environment") + BASH_VERSINFO=([0]="5" [1]="2" [2]="21" [3]="1" [4]="release" [5]="i686-pc-linux-gnu") + BASH_VERSION='5.2.21(1)-release' + BUILDDIR=/build/reproducible-path + BUILDUSERGECOS='second user,second room,second work-phone,second home-phone,second other' + BUILDUSERNAME=pbuilder2 + BUILD_ARCH=i386 + DEBIAN_FRONTEND=noninteractive + DEB_BUILD_OPTIONS='buildinfo=+all reproducible=+all parallel=10 ' + DIRSTACK=() + DISTRIBUTION=trixie + EUID=0 + FUNCNAME=([0]="Echo" [1]="main") + GROUPS=() + HOME=/root + HOSTNAME=i-capture-the-hostname + HOSTTYPE=i686 + HOST_ARCH=i386 IFS=' ' - INVOCATION_ID='7f610905767149e0b006970af4a1df5d' - LANG='C' - LANGUAGE='en_US:en' - LC_ALL='C' - LD_LIBRARY_PATH='/usr/lib/libeatmydata' - LD_PRELOAD='libeatmydata.so' - MAIL='/var/mail/root' - OPTIND='1' - PATH='/usr/sbin:/usr/bin:/sbin:/bin:/usr/games' - PBCURRENTCOMMANDLINEOPERATION='build' - PBUILDER_OPERATION='build' - PBUILDER_PKGDATADIR='/usr/share/pbuilder' - PBUILDER_PKGLIBDIR='/usr/lib/pbuilder' - PBUILDER_SYSCONFDIR='/etc' - PPID='92801' - PS1='# ' - PS2='> ' + INVOCATION_ID=0d541a3bdeb24a09b1aa14cd0b9c3049 + LANG=C + LANGUAGE=de_CH:de + LC_ALL=C + LD_LIBRARY_PATH=/usr/lib/libeatmydata + LD_PRELOAD=libeatmydata.so + MACHTYPE=i686-pc-linux-gnu + MAIL=/var/mail/root + OPTERR=1 + OPTIND=1 + OSTYPE=linux-gnu + PATH=/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/i/capture/the/path + PBCURRENTCOMMANDLINEOPERATION=build + PBUILDER_OPERATION=build + PBUILDER_PKGDATADIR=/usr/share/pbuilder + PBUILDER_PKGLIBDIR=/usr/lib/pbuilder + PBUILDER_SYSCONFDIR=/etc + PIPESTATUS=([0]="0") + POSIXLY_CORRECT=y + PPID=61333 PS4='+ ' - PWD='/' - SHELL='/bin/bash' - SHLVL='2' - SUDO_COMMAND='/usr/bin/timeout -k 18.1h 18h /usr/bin/ionice -c 3 /usr/bin/nice /usr/sbin/pbuilder --build --configfile /srv/reproducible-results/rbuild-debian/r-b-build.7ZYR5CcC/pbuilderrc_fzQ7 --distribution trixie --hookdir /etc/pbuilder/first-build-hooks --debbuildopts -b --basetgz /var/cache/pbuilder/trixie-reproducible-base.tgz --buildresult /srv/reproducible-results/rbuild-debian/r-b-build.7ZYR5CcC/b1 --logfile b1/build.log ksmbd-tools_3.5.2-2.dsc' - SUDO_GID='112' - SUDO_UID='107' - SUDO_USER='jenkins' - TERM='unknown' - TZ='/usr/share/zoneinfo/Etc/GMT+12' - USER='root' - _='/usr/bin/systemd-run' - http_proxy='http://213.165.73.152:3128' + PWD=/ + SHELL=/bin/bash + SHELLOPTS=braceexpand:errexit:hashall:interactive-comments:posix + SHLVL=3 + SUDO_COMMAND='/usr/bin/timeout -k 24.1h 24h /usr/bin/ionice -c 3 /usr/bin/nice -n 11 /usr/bin/unshare --uts -- /usr/sbin/pbuilder --build --configfile /srv/reproducible-results/rbuild-debian/r-b-build.7ZYR5CcC/pbuilderrc_3H1a --distribution trixie --hookdir /etc/pbuilder/rebuild-hooks --debbuildopts -b --basetgz /var/cache/pbuilder/trixie-reproducible-base.tgz --buildresult /srv/reproducible-results/rbuild-debian/r-b-build.7ZYR5CcC/b2 --logfile b2/build.log ksmbd-tools_3.5.2-2.dsc' + SUDO_GID=112 + SUDO_UID=107 + SUDO_USER=jenkins + TERM=unknown + TZ=/usr/share/zoneinfo/Etc/GMT-14 + UID=0 + USER=root + _='I: set' + http_proxy=http://46.16.76.132:3128 I: uname -a - Linux ionos6-i386 6.1.0-21-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.90-1 (2024-05-03) x86_64 GNU/Linux + Linux i-capture-the-hostname 6.1.0-21-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.90-1 (2024-05-03) x86_64 GNU/Linux I: ls -l /bin - lrwxrwxrwx 1 root root 7 Jun 13 17:56 /bin -> usr/bin -I: user script /srv/workspace/pbuilder/92801/tmp/hooks/D02_print_environment finished + lrwxrwxrwx 1 root root 7 May 13 11:24 /bin -> usr/bin +I: user script /srv/workspace/pbuilder/61333/tmp/hooks/D02_print_environment finished -> Attempting to satisfy build-dependencies -> Creating pbuilder-satisfydepends-dummy package Package: pbuilder-satisfydepends-dummy @@ -188,7 +220,7 @@ Get: 67 http://deb.debian.org/debian trixie/main i386 libnl-3-dev i386 3.7.0-0.3 [105 kB] Get: 68 http://deb.debian.org/debian trixie/main i386 libnl-genl-3-200 i386 3.7.0-0.3 [18.3 kB] Get: 69 http://deb.debian.org/debian trixie/main i386 libnl-genl-3-dev i386 3.7.0-0.3 [18.1 kB] -Fetched 33.8 MB in 1s (36.5 MB/s) +Fetched 33.8 MB in 1s (63.5 MB/s) debconf: delaying package configuration, since apt-utils is not installed Selecting previously unselected package libpython3.11-minimal:i386. (Reading database ... (Reading database ... 5% (Reading database ... 10% (Reading database ... 15% (Reading database ... 20% (Reading database ... 25% (Reading database ... 30% (Reading database ... 35% (Reading database ... 40% (Reading database ... 45% (Reading database ... 50% (Reading database ... 55% (Reading database ... 60% (Reading database ... 65% (Reading database ... 70% (Reading database ... 75% (Reading database ... 80% (Reading database ... 85% (Reading database ... 90% (Reading database ... 95% (Reading database ... 100% (Reading database ... 19684 files and directories currently installed.) @@ -425,8 +457,8 @@ Setting up tzdata (2024a-4) ... Current default time zone: 'Etc/UTC' -Local time is now: Mon Jun 16 01:55:11 UTC 2025. -Universal Time is now: Mon Jun 16 01:55:11 UTC 2025. +Local time is now: Mon May 13 19:33:01 UTC 2024. +Universal Time is now: Mon May 13 19:33:01 UTC 2024. Run 'dpkg-reconfigure tzdata' if you wish to change it. Setting up libsysprof-capture-4-dev:i386 (46.0-1) ... @@ -492,7 +524,11 @@ Building tag database... -> Finished parsing the build-deps I: Building the package -I: Running cd /build/reproducible-path/ksmbd-tools-3.5.2/ && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games" HOME="/nonexistent/first-build" dpkg-buildpackage -us -uc -b && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games" HOME="/nonexistent/first-build" dpkg-genchanges -S > ../ksmbd-tools_3.5.2-2_source.changes +I: user script /srv/workspace/pbuilder/61333/tmp/hooks/A99_set_merged_usr starting +Not re-configuring usrmerge for trixie +I: user script /srv/workspace/pbuilder/61333/tmp/hooks/A99_set_merged_usr finished +hostname: Name or service not known +I: Running cd /build/reproducible-path/ksmbd-tools-3.5.2/ && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/i/capture/the/path" HOME="/nonexistent/second-build" dpkg-buildpackage -us -uc -b && env PATH="/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/i/capture/the/path" HOME="/nonexistent/second-build" dpkg-genchanges -S > ../ksmbd-tools_3.5.2-2_source.changes dpkg-buildpackage: info: source package ksmbd-tools dpkg-buildpackage: info: source version 3.5.2-2 dpkg-buildpackage: info: source distribution unstable @@ -646,7 +682,7 @@ config.status: executing depfiles commands config.status: executing libtool commands dh_auto_build - make -j22 + make -j10 make[1]: Entering directory '/build/reproducible-path/ksmbd-tools-3.5.2' make all-recursive make[2]: Entering directory '/build/reproducible-path/ksmbd-tools-3.5.2' @@ -656,6 +692,11 @@ gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -DSYSCONFDIR='"/etc"' -DRUNSTATEDIR='"/run"' -I../include -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -I/usr/include/libnl3 -fno-common -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/ksmbd-tools-3.5.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic -c -o addshare.o addshare.c In file included from addshare.c:21: addshare.c: In function 'addshare_main': +share_admin.c: In function '__load_conf': +share_admin.c:124:43: warning: non-ISO-standard escape sequence, '\e' + 124 | printf("\r" "\e[2K" "%s%s" "\e[6n", option, buf); + | ^ +share_admin.c:124:43: warning: non-ISO-standard escape sequence, '\e' ../include/tools.h:124:34: warning: ISO C does not support the '%m' gnu_printf format [-Wformat=] 124 | (f), \ | ^~~ @@ -665,11 +706,6 @@ addshare.c:159:17: note: in expansion of macro 'pr_debug' 159 | pr_debug("Can't send SIGHUP to PID %d: %m\n", | ^~~~~~~~ -share_admin.c: In function '__load_conf': -share_admin.c:124:43: warning: non-ISO-standard escape sequence, '\e' - 124 | printf("\r" "\e[2K" "%s%s" "\e[6n", option, buf); - | ^ -share_admin.c:124:43: warning: non-ISO-standard escape sequence, '\e' share_admin.c: In function '__next_conf': share_admin.c:142:76: warning: non-ISO-standard escape sequence, '\e' 142 | printf("\eD" "\r" "\e[1m" "Ready to commit changes!" "\e[m"); @@ -751,17 +787,6 @@ md4_hash.c:203:16: warning: overflow in conversion from 'int' to 'char' changes value from '128' to '-128' [-Woverflow] 203 | *p++ = 0x80; | ^~~~ -In file included from adduser.c:21: -adduser.c: In function 'adduser_main': -../include/tools.h:124:34: warning: ISO C does not support the '%m' gnu_printf format [-Wformat=] - 124 | (f), \ - | ^~~ -../include/tools.h:131:9: note: in expansion of macro 'pr_log' - 131 | pr_log(PR_DEBUG, PRDEBUG f, ##__VA_ARGS__) - | ^~~~~~ -adduser.c:159:17: note: in expansion of macro 'pr_debug' - 159 | pr_debug("Can't send SIGHUP to PID %d: %m\n", - | ^~~~~~~~ user_admin.c: In function '__prompt_password_stdin': user_admin.c:46:60: warning: non-ISO-standard escape sequence, '\e' 46 | printf("\r" "\e[2K" "%s password: ", @@ -822,6 +847,17 @@ ../include/tools.h:141:36: note: expected 'unsigned char *' but argument is of type 'char *' 141 | char *base64_encode(unsigned char *src, size_t srclen); | ~~~~~~~~~~~~~~~^~~ +In file included from adduser.c:21: +adduser.c: In function 'adduser_main': +../include/tools.h:124:34: warning: ISO C does not support the '%m' gnu_printf format [-Wformat=] + 124 | (f), \ + | ^~~ +../include/tools.h:131:9: note: in expansion of macro 'pr_log' + 131 | pr_log(PR_DEBUG, PRDEBUG f, ##__VA_ARGS__) + | ^~~~~~ +adduser.c:159:17: note: in expansion of macro 'pr_debug' + 159 | pr_debug("Can't send SIGHUP to PID %d: %m\n", + | ^~~~~~~~ user_admin.c: In function '__prompt_password_stdin': user_admin.c:55:33: warning: '__builtin_strncat' output may be truncated copying 128 bytes from a string of length 2047 [-Wstringop-truncation] 55 | strncat(password, buf, MAX_NT_PWD_LEN - 1); @@ -1000,28 +1036,64 @@ gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -DSYSCONFDIR='"/etc"' -DRUNSTATEDIR='"/run"' -I../include -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -I/usr/include/libnl3 -fno-common -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/ksmbd-tools-3.5.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic -c -o smbacl.o smbacl.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -DSYSCONFDIR='"/etc"' -DRUNSTATEDIR='"/run"' -I../include -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -I/usr/include/libnl3 -fno-common -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/ksmbd-tools-3.5.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic -c -o rpc_samr.o rpc_samr.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -DSYSCONFDIR='"/etc"' -DRUNSTATEDIR='"/run"' -I../include -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -I/usr/include/libnl3 -fno-common -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/ksmbd-tools-3.5.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic -c -o rpc_lsarpc.o rpc_lsarpc.c +rpc.c: In function 'align_offset': +rpc.c:91:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] + 91 | ({ \ + | ^ +rpc.c:224:23: note: in expansion of macro '__ALIGN' + 224 | dce->offset = __ALIGN(dce->offset, n); + | ^~~~~~~ +rpc.c: In function 'auto_align_offset': +rpc.c:91:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] + 91 | ({ \ + | ^ +rpc.c:230:31: note: in expansion of macro '__ALIGN' + 230 | dce->offset = __ALIGN(dce->offset, 8); + | ^~~~~~~ +rpc.c:91:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] + 91 | ({ \ + | ^ +rpc.c:232:31: note: in expansion of macro '__ALIGN' + 232 | dce->offset = __ALIGN(dce->offset, 4); + | ^~~~~~~ +rpc.c: At top level: +rpc.c:281:45: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 281 | NDR_WRITE_INT(int8, __u8, htobe_n, htole_n); + | ^ +rpc.c:282:46: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 282 | NDR_WRITE_INT(int16, __u16, htobe16, htole16); + | ^ +rpc.c:283:46: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 283 | NDR_WRITE_INT(int32, __u32, htobe32, htole32); + | ^ In file included from worker.c:14: ../include/ipc.h:26:25: warning: ISO C forbids zero-size array '____payload' [-Wpedantic] 26 | unsigned char ____payload[0]; | ^~~~~~~~~~~ -rpc_samr.c: In function 'samr_connect5_invoke': -rpc_samr.c:95:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] - 95 | if (ndr_read_int32(dce, &dce->sm_req.level)) - | ^~~~~~~~~~~~~~~~~~ - | | - | int * -In file included from rpc_samr.c:15: -../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' - 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); - | ~~~~~~~^~~~~ -rpc_samr.c:100:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] - 100 | if (ndr_read_int32(dce, &dce->sm_req.client_version)) - | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ - | | - | int * -../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' - 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); - | ~~~~~~~^~~~~ +rpc.c:284:46: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 284 | NDR_WRITE_INT(int64, __u64, htobe64, htole64); + | ^ +rpc.c:305:44: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 305 | NDR_READ_INT(int8, __u8, betoh_n, letoh_n); + | ^ +rpc.c:306:45: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 306 | NDR_READ_INT(int16, __u16, be16toh, le16toh); + | ^ +rpc.c:307:45: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 307 | NDR_READ_INT(int32, __u32, be32toh, le32toh); + | ^ +rpc.c:308:45: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 308 | NDR_READ_INT(int64, __u64, be64toh, le64toh); + | ^ +rpc.c:329:30: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 329 | NDR_WRITE_UNION(int16, __u16); + | ^ +rpc.c:330:30: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 330 | NDR_WRITE_UNION(int32, __u32); + | ^ +rpc.c:351:29: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] + 351 | NDR_READ_UNION(int32, __u32); + | ^ worker.c: In function 'login_request': worker.c:26:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] 26 | ({ \ @@ -1030,7 +1102,6 @@ 49 | if (VALID_IPC_MSG(msg, struct ksmbd_login_request)) | ^~~~~~~~~~~~~ worker.c: In function 'spnego_authen_request': -rpc_wkssvc.c: In function 'wkssvc_parse_netwksta_info_req': worker.c:105:26: warning: pointer targets in passing argument 1 of 'strncpy' differ in signedness [-Wpointer-sign] 105 | strncpy(login_req.account, auth_out.user_name, | ~~~~~~~~~^~~~~~~~ @@ -1042,16 +1113,19 @@ /usr/include/i386-linux-gnu/bits/string_fortified.h:92:1: note: expected 'char * restrict' but argument is of type '__s8 *' {aka 'signed char *'} 92 | __NTH (strncpy (char *__restrict __dest, const char *__restrict __src, | ^~~~~ -rpc_wkssvc.c:169:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] - 169 | if (ndr_read_int32(dce, &val)) - | ^~~~ +rpc.c: In function 'ndr_read_vstring': +worker.c: In function 'tree_connect_request': +rpc.c:524:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] + 524 | if (ndr_read_int32(dce, &raw_len)) + | ^~~~~~~~ | | | int * -In file included from rpc_wkssvc.c:16: -../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' - 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); - | ~~~~~~~^~~~~ -worker.c: In function 'tree_connect_request': +rpc.c:287:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' + 287 | int ndr_read_##name(struct ksmbd_dcerpc *dce, type *value) \ + | ^ +rpc.c:307:1: note: in expansion of macro 'NDR_READ_INT' + 307 | NDR_READ_INT(int32, __u32, be32toh, le32toh); + | ^~~~~~~~~~~~ worker.c:26:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] 26 | ({ \ | ^ @@ -1059,21 +1133,12 @@ 146 | if (VALID_IPC_MSG(msg, struct ksmbd_tree_connect_request)) | ^~~~~~~~~~~~~ worker.c: In function 'share_config_request': -rpc_samr.c: In function 'samr_lookup_names_invoke': worker.c:26:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] 26 | ({ \ | ^ worker.c:167:13: note: in expansion of macro 'VALID_IPC_MSG' 167 | if (VALID_IPC_MSG(msg, struct ksmbd_share_config_request)) { | ^~~~~~~~~~~~~ -rpc_samr.c:303:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] - 303 | if (ndr_read_int32(dce, &user_num)) - | ^~~~~~~~~ - | | - | int * -../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' - 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); - | ~~~~~~~^~~~~ worker.c:168:45: warning: pointer targets in passing argument 1 of 'shm_lookup_share' differ in signedness [-Wpointer-sign] 168 | share = shm_lookup_share(req->share_name); | ~~~^~~~~~~~~~~~ @@ -1083,16 +1148,6 @@ ../include/management/share.h:154:44: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 154 | struct ksmbd_share *shm_lookup_share(char *name); | ~~~~~~^~~~ -rpc_srvsvc.c: In function 'srvsvc_parse_share_info_req': -rpc_srvsvc.c:310:41: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] - 310 | if (ndr_read_int32(dce, &ptr)) - | ^~~~ - | | - | int * -In file included from rpc_srvsvc.c:16: -../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' - 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); - | ~~~~~~~^~~~~ worker.c: In function 'tree_disconnect_request': worker.c:26:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] 26 | ({ \ @@ -1107,31 +1162,31 @@ worker.c:205:14: note: in expansion of macro 'VALID_IPC_MSG' 205 | if (!VALID_IPC_MSG(msg, struct ksmbd_logout_request)) | ^~~~~~~~~~~~~ -rpc_lsarpc.c: In function 'lsarpc_lookup_names3_invoke': -rpc_srvsvc.c:329:41: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] - 329 | if (ndr_read_int32(dce, &hdr->level)) - | ^~~~~~~~~~~ +worker.c: In function 'heartbeat_request': +worker.c:26:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] + 26 | ({ \ + | ^ +worker.c:213:14: note: in expansion of macro 'VALID_IPC_MSG' + 213 | if (!VALID_IPC_MSG(msg, struct ksmbd_heartbeat)) + | ^~~~~~~~~~~~~ +rpc_srvsvc.c: In function 'srvsvc_parse_share_info_req': +rpc_srvsvc.c:310:41: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] + 310 | if (ndr_read_int32(dce, &ptr)) + | ^~~~ | | | int * +In file included from rpc_srvsvc.c:16: ../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); | ~~~~~~~^~~~~ -rpc_lsarpc.c:444:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] - 444 | if (ndr_read_int32(dce, &num_names)) - | ^~~~~~~~~~ - | | - | int * -In file included from rpc_lsarpc.c:16: +rpc_srvsvc.c:329:41: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] + 329 | if (ndr_read_int32(dce, &hdr->level)) + | ^~~~~~~~~~~ + | | + | int * ../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); | ~~~~~~~^~~~~ -worker.c: In function 'heartbeat_request': -worker.c:26:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] - 26 | ({ \ - | ^ -worker.c:213:14: note: in expansion of macro 'VALID_IPC_MSG' - 213 | if (!VALID_IPC_MSG(msg, struct ksmbd_heartbeat)) - | ^~~~~~~~~~~~~ In file included from mountd.c:22: ../include/ipc.h:26:25: warning: ISO C forbids zero-size array '____payload' [-Wpedantic] 26 | unsigned char ____payload[0]; @@ -1145,17 +1200,6 @@ 71 | dprintf(wfd, "\e[1m" LIST_FMT_SS "\e[m" "\n", "Name", "Comment"); | ^ mountd.c:71:53: warning: non-ISO-standard escape sequence, '\e' -rpc_samr.c: In function 'samr_query_security_return': -rpc_samr.c:745:33: warning: pointer targets in passing argument 2 of 'build_sec_desc' differ in signedness [-Wpointer-sign] - 745 | if (build_sec_desc(dce, &sec_desc_len, ch->user->uid)) - | ^~~~~~~~~~~~~ - | | - | int * -In file included from ../include/rpc_samr.h:11, - from rpc_samr.c:16: -../include/smbacl.h:79:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' - 79 | int build_sec_desc(struct ksmbd_dcerpc *dce, __u32 *secdesclen, int rid); - | ~~~~~~~^~~~~~~~~~ In file included from mountd.c:11: mountd.c: In function 'worker_init_wait': ../include/tools.h:124:34: warning: ISO C does not support the '%m' gnu_printf format [-Wformat=] @@ -1214,6 +1258,12 @@ mountd.c:365:25: note: in expansion of macro 'pr_err' 365 | pr_err("Can't redirect stream: %m\n"); | ^~~~~~ +rpc_wkssvc.c: In function 'wkssvc_parse_netwksta_info_req': +rpc_wkssvc.c:169:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] + 169 | if (ndr_read_int32(dce, &val)) + | ^~~~ + | | + | int * ../include/tools.h:124:34: warning: ISO C does not support the '%m' gnu_printf format [-Wformat=] 124 | (f), \ | ^~~ @@ -1223,77 +1273,53 @@ mountd.c:390:25: note: in expansion of macro 'pr_err' 390 | pr_err("Can't send SIGUSR1 to PID %d: %m\n", ppid); | ^~~~~~ +In file included from rpc_wkssvc.c:16: +../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' + 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); + | ~~~~~~~^~~~~ mountd.c: In function 'mountd_main': mountd.c:420:45: warning: ISO C forbids omitting the middle term of a '?:' expression [-Wpedantic] 420 | nodetach = !optarg ?: cp_get_group_kv_long(optarg); | ^ mountd.c:420:45: warning: the omitted middle operand in '?:' will always be 'true', suggest explicit middle operand [-Wparentheses] -rpc.c: In function 'align_offset': -rpc.c:91:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] - 91 | ({ \ - | ^ -rpc.c:224:23: note: in expansion of macro '__ALIGN' - 224 | dce->offset = __ALIGN(dce->offset, n); - | ^~~~~~~ -rpc.c: In function 'auto_align_offset': -rpc.c:91:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] - 91 | ({ \ - | ^ -rpc.c:230:31: note: in expansion of macro '__ALIGN' - 230 | dce->offset = __ALIGN(dce->offset, 8); - | ^~~~~~~ -rpc.c:91:9: warning: ISO C forbids braced-groups within expressions [-Wpedantic] - 91 | ({ \ - | ^ -rpc.c:232:31: note: in expansion of macro '__ALIGN' - 232 | dce->offset = __ALIGN(dce->offset, 4); - | ^~~~~~~ -rpc.c: At top level: -rpc.c:281:45: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 281 | NDR_WRITE_INT(int8, __u8, htobe_n, htole_n); - | ^ -rpc.c:282:46: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 282 | NDR_WRITE_INT(int16, __u16, htobe16, htole16); - | ^ -rpc.c:283:46: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 283 | NDR_WRITE_INT(int32, __u32, htobe32, htole32); - | ^ -rpc.c:284:46: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 284 | NDR_WRITE_INT(int64, __u64, htobe64, htole64); - | ^ -rpc.c:305:44: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 305 | NDR_READ_INT(int8, __u8, betoh_n, letoh_n); - | ^ -rpc.c:306:45: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 306 | NDR_READ_INT(int16, __u16, be16toh, le16toh); - | ^ -rpc.c:307:45: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 307 | NDR_READ_INT(int32, __u32, be32toh, le32toh); - | ^ -rpc.c:308:45: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 308 | NDR_READ_INT(int64, __u64, be64toh, le64toh); - | ^ -rpc.c:329:30: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 329 | NDR_WRITE_UNION(int16, __u16); - | ^ -rpc.c:330:30: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 330 | NDR_WRITE_UNION(int32, __u32); - | ^ -rpc.c:351:29: warning: ISO C does not allow extra ';' outside of a function [-Wpedantic] - 351 | NDR_READ_UNION(int32, __u32); - | ^ -rpc.c: In function 'ndr_read_vstring': -rpc.c:524:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] - 524 | if (ndr_read_int32(dce, &raw_len)) - | ^~~~~~~~ +rpc_samr.c: In function 'samr_connect5_invoke': +rpc_samr.c:95:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] + 95 | if (ndr_read_int32(dce, &dce->sm_req.level)) + | ^~~~~~~~~~~~~~~~~~ | | | int * -rpc.c:287:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' - 287 | int ndr_read_##name(struct ksmbd_dcerpc *dce, type *value) \ - | ^ -rpc.c:307:1: note: in expansion of macro 'NDR_READ_INT' - 307 | NDR_READ_INT(int32, __u32, be32toh, le32toh); - | ^~~~~~~~~~~~ +In file included from rpc_samr.c:15: +../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' + 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); + | ~~~~~~~^~~~~ +rpc_samr.c:100:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] + 100 | if (ndr_read_int32(dce, &dce->sm_req.client_version)) + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ + | | + | int * +../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' + 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); + | ~~~~~~~^~~~~ +rpc_samr.c: In function 'samr_lookup_names_invoke': +rpc_samr.c:303:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] + 303 | if (ndr_read_int32(dce, &user_num)) + | ^~~~~~~~~ + | | + | int * +../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' + 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); + | ~~~~~~~^~~~~ +rpc_samr.c: In function 'samr_query_security_return': +rpc_samr.c:745:33: warning: pointer targets in passing argument 2 of 'build_sec_desc' differ in signedness [-Wpointer-sign] + 745 | if (build_sec_desc(dce, &sec_desc_len, ch->user->uid)) + | ^~~~~~~~~~~~~ + | | + | int * +In file included from ../include/rpc_samr.h:11, + from rpc_samr.c:16: +../include/smbacl.h:79:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' + 79 | int build_sec_desc(struct ksmbd_dcerpc *dce, __u32 *secdesclen, int rid); + | ~~~~~~~^~~~~~~~~~ In file included from ipc.c:21: ../include/ipc.h:26:25: warning: ISO C forbids zero-size array '____payload' [-Wpedantic] 26 | unsigned char ____payload[0]; @@ -1349,8 +1375,18 @@ ipc.c:180:40: note: in expansion of macro 'KSMBD_STARTUP_CONFIG_INTERFACES' 180 | char *config_payload = KSMBD_STARTUP_CONFIG_INTERFACES(ev); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +rpc_lsarpc.c: In function 'lsarpc_lookup_names3_invoke': In file included from ipc.c:20: ipc.c: In function 'ipc_process_event': +rpc_lsarpc.c:444:33: warning: pointer targets in passing argument 2 of 'ndr_read_int32' differ in signedness [-Wpointer-sign] + 444 | if (ndr_read_int32(dce, &num_names)) + | ^~~~~~~~~~ + | | + | int * +In file included from rpc_lsarpc.c:16: +../include/rpc.h:303:53: note: expected '__u32 *' {aka 'unsigned int *'} but argument is of type 'int *' + 303 | int ndr_read_int32(struct ksmbd_dcerpc *dce, __u32 *value); + | ~~~~~~~^~~~~ ../include/tools.h:124:34: warning: ISO C does not support the '%m' gnu_printf format [-Wformat=] 124 | (f), \ | ^~~ @@ -1373,66 +1409,16 @@ gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -DSYSCONFDIR='"/etc"' -DRUNSTATEDIR='"/run"' -I../include -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -fno-common -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/ksmbd-tools-3.5.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic -c -o management/user.o management/user.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -DSYSCONFDIR='"/etc"' -DRUNSTATEDIR='"/run"' -I../include -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -fno-common -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/ksmbd-tools-3.5.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic -c -o management/share.o management/share.c gcc -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -DSYSCONFDIR='"/etc"' -DRUNSTATEDIR='"/run"' -I../include -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -fno-common -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/ksmbd-tools-3.5.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic -c -o management/session.o management/session.c -In file included from tools.c:16: -../include/ipc.h:26:25: warning: ISO C forbids zero-size array '____payload' [-Wpedantic] - 26 | unsigned char ____payload[0]; - | ^~~~~~~~~~~ -config_parser.c: In function 'is_a_key_value': -config_parser.c:106:45: warning: pointer targets in passing argument 1 of 'cp_printable' differ in signedness [-Wpointer-sign] - 106 | is_key_value = cp_printable(entry) && !cp_smbconf_eol(entry); - | ^~~~~ - | | - | char * -In file included from config_parser.c:17: -../include/config_parser.h:25:47: note: expected 'unsigned char *' but argument is of type 'char *' - 25 | static inline int cp_printable(unsigned char *p) - | ~~~~~~~~~~~~~~~^ -config_parser.c:121:45: warning: pointer targets in passing argument 1 of 'cp_printable' differ in signedness [-Wpointer-sign] - 121 | is_key_value = cp_printable(entry) || *entry == '\t'; - | ^~~~~ - | | - | char * -../include/config_parser.h:25:47: note: expected 'unsigned char *' but argument is of type 'char *' - 25 | static inline int cp_printable(unsigned char *p) - | ~~~~~~~~~~~~~~~^ management/tree_conn.c: In function 'tcm_handle_tree_connect': -In file included from config_parser.c:18: -config_parser.c: In function '__mmap_parse_file': management/tree_conn.c:65:37: warning: pointer targets in passing argument 1 of 'shm_lookup_share' differ in signedness [-Wpointer-sign] 65 | share = shm_lookup_share(req->share); | ~~~^~~~~~~ | | | __s8 * {aka signed char *} -../include/tools.h:124:34: warning: ISO C does not support the '%m' gnu_printf format [-Wformat=] - 124 | (f), \ - | ^~~ -../include/tools.h:131:9: note: in expansion of macro 'pr_log' - 131 | pr_log(PR_DEBUG, PRDEBUG f, ##__VA_ARGS__) - | ^~~~~~ -config_parser.c:206:17: note: in expansion of macro 'pr_debug' - 206 | pr_debug("Can't open `%s': %m\n", path); - | ^~~~~~~~ In file included from management/tree_conn.c:15: ../include/management/share.h:154:44: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 154 | struct ksmbd_share *shm_lookup_share(char *name); | ~~~~~~^~~~ -management/user.c: In function 'new_ksmbd_user': -management/user.c:121:20: warning: pointer targets in assignment from 'unsigned char *' to 'char *' differ in signedness [-Wpointer-sign] - 121 | user->pass = base64_decode(user->pass_b64, &pass_sz); - | ^ -management/share.c: In function 'shm_share_name': -management/share.c:129:40: warning: pointer targets in passing argument 1 of 'cp_printable' differ in signedness [-Wpointer-sign] - 129 | is_name = cp_printable(name) && *name != '[' && *name != ']'; - | ^~~~ - | | - | char * -In file included from management/share.c:17: -../include/config_parser.h:25:47: note: expected 'unsigned char *' but argument is of type 'char *' - 25 | static inline int cp_printable(unsigned char *p) - | ~~~~~~~~~~~~~~~^ -config_parser.c:231:54: warning: ISO C forbids omitting the middle term of a '?:' expression [-Wpedantic] - 231 | delim = memchr(contents, '\n', len) ?: contents + len; - | ^ management/tree_conn.c:87:39: warning: pointer targets in passing argument 3 of 'shm_lookup_hosts_map' differ in signedness [-Wpointer-sign] 87 | req->peer_addr); | ~~~^~~~~~~~~~~ @@ -1441,16 +1427,6 @@ ../include/management/share.h:172:33: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 172 | char *host); | ~~~~~~^~~~ -management/user.c: In function 'usm_user_name': -management/user.c:194:40: warning: pointer targets in passing argument 1 of 'cp_printable' differ in signedness [-Wpointer-sign] - 194 | is_name = cp_printable(name) && *name != ':'; - | ^~~~ - | | - | char * -In file included from management/user.c:17: -../include/config_parser.h:25:47: note: expected 'unsigned char *' but argument is of type 'char *' - 25 | static inline int cp_printable(unsigned char *p) - | ~~~~~~~~~~~~~~~^ management/tree_conn.c:97:47: warning: pointer targets in passing argument 3 of 'shm_lookup_hosts_map' differ in signedness [-Wpointer-sign] 97 | req->peer_addr); | ~~~^~~~~~~~~~~ @@ -1464,14 +1440,10 @@ | ~~~^~~~~~~~~ | | | __s8 * {aka signed char *} -management/user.c: In function 'usm_update_user_password': In file included from management/tree_conn.c:16: ../include/management/user.h:46:42: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 46 | struct ksmbd_user *usm_lookup_user(char *name); | ~~~~~~^~~~ -management/user.c:272:22: warning: pointer targets in initialization of 'char *' from 'unsigned char *' differ in signedness [-Wpointer-sign] - 272 | char *pass = base64_decode(pass_b64, &pass_sz); - | ^~~~~~~~~~~~~ management/tree_conn.c:158:39: warning: pointer targets in passing argument 3 of 'shm_lookup_users_map' differ in signedness [-Wpointer-sign] 158 | req->account); | ~~~^~~~~~~~~ @@ -1485,18 +1457,9 @@ | ~~~^~~~~~~~~ | | | __s8 * {aka signed char *} -management/user.c: In function '__handle_login_request': ../include/management/share.h:168:33: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 168 | char *name); | ~~~~~~^~~~ -management/user.c:332:46: warning: pointer targets in passing argument 2 of 'usm_copy_user_passhash' differ in signedness [-Wpointer-sign] - 332 | resp->hash, - | ~~~~^~~~~~ - | | - | __s8 * {aka signed char *} -management/user.c:285:41: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} - 285 | char *pass, - | ~~~~~~^~~~ management/tree_conn.c:175:39: warning: pointer targets in passing argument 3 of 'shm_lookup_users_map' differ in signedness [-Wpointer-sign] 175 | req->account); | ~~~^~~~~~~~~ @@ -1513,11 +1476,6 @@ ../include/management/share.h:168:33: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 168 | char *name); | ~~~~~~^~~~ -management/user.c:339:47: warning: pointer targets in passing argument 2 of 'usm_copy_user_account' differ in signedness [-Wpointer-sign] - 339 | resp->account, - | ~~~~^~~~~~~~~ - | | - | __s8 * {aka signed char *} management/tree_conn.c:192:39: warning: pointer targets in passing argument 3 of 'shm_lookup_users_map' differ in signedness [-Wpointer-sign] 192 | req->account); | ~~~^~~~~~~~~ @@ -1526,6 +1484,48 @@ ../include/management/share.h:168:33: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 168 | char *name); | ~~~~~~^~~~ +management/share.c: In function 'shm_share_name': +management/user.c: In function 'new_ksmbd_user': +management/share.c:129:40: warning: pointer targets in passing argument 1 of 'cp_printable' differ in signedness [-Wpointer-sign] + 129 | is_name = cp_printable(name) && *name != '[' && *name != ']'; + | ^~~~ + | | + | char * +management/user.c:121:20: warning: pointer targets in assignment from 'unsigned char *' to 'char *' differ in signedness [-Wpointer-sign] + 121 | user->pass = base64_decode(user->pass_b64, &pass_sz); + | ^ +In file included from management/share.c:17: +../include/config_parser.h:25:47: note: expected 'unsigned char *' but argument is of type 'char *' + 25 | static inline int cp_printable(unsigned char *p) + | ~~~~~~~~~~~~~~~^ +management/user.c: In function 'usm_user_name': +management/user.c:194:40: warning: pointer targets in passing argument 1 of 'cp_printable' differ in signedness [-Wpointer-sign] + 194 | is_name = cp_printable(name) && *name != ':'; + | ^~~~ + | | + | char * +In file included from management/user.c:17: +../include/config_parser.h:25:47: note: expected 'unsigned char *' but argument is of type 'char *' + 25 | static inline int cp_printable(unsigned char *p) + | ~~~~~~~~~~~~~~~^ +management/user.c: In function 'usm_update_user_password': +management/user.c:272:22: warning: pointer targets in initialization of 'char *' from 'unsigned char *' differ in signedness [-Wpointer-sign] + 272 | char *pass = base64_decode(pass_b64, &pass_sz); + | ^~~~~~~~~~~~~ +management/user.c: In function '__handle_login_request': +management/user.c:332:46: warning: pointer targets in passing argument 2 of 'usm_copy_user_passhash' differ in signedness [-Wpointer-sign] + 332 | resp->hash, + | ~~~~^~~~~~ + | | + | __s8 * {aka signed char *} +management/user.c:285:41: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} + 285 | char *pass, + | ~~~~~~^~~~ +management/user.c:339:47: warning: pointer targets in passing argument 2 of 'usm_copy_user_account' differ in signedness [-Wpointer-sign] + 339 | resp->account, + | ~~~~^~~~~~~~~ + | | + | __s8 * {aka signed char *} management/user.c:304:40: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 304 | char *account, | ~~~~~~^~~~~~~ @@ -1547,10 +1547,6 @@ management/user.c:155:42: note: expected 'char *' but argument is of type '__s8 *' {aka 'signed char *'} 155 | struct ksmbd_user *usm_lookup_user(char *name) | ~~~~~~^~~~ -config_parser.c: In function 'cp_parse_subauth': -config_parser.c:821:43: warning: ISO C forbids omitting the middle term of a '?:' expression [-Wpedantic] - 821 | contents ?: "", - | ^ management/share.c: In function 'shm_handle_share_config_request': management/share.c:913:21: warning: pointer targets in passing argument 1 of 'strncat' differ in signedness [-Wpointer-sign] 913 | strncat(resp->share_name, share->name, KSMBD_REQ_MAX_SHARE_NAME - 1); @@ -1583,7 +1579,47 @@ /usr/include/i386-linux-gnu/bits/stdio2.h:28:1: note: expected 'char * restrict' but argument is of type 'unsigned char *' 28 | __NTH (sprintf (char *__restrict __s, const char *__restrict __fmt, ...)) | ^~~~~ -/bin/bash ../libtool --tag=CC --mode=link gcc -DSYSCONFDIR='"/etc"' -DRUNSTATEDIR='"/run"' -I../include -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -fno-common -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/ksmbd-tools-3.5.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic -Wl,-z,relro -Wl,-z,now -o ksmbd.tools management/tree_conn.o management/user.o management/share.o management/session.o config_parser.o tools.o ../addshare/libaddshare.a ../adduser/libadduser.a ../control/libcontrol.a ../mountd/libmountd.a -lglib-2.0 -lnl-genl-3 -lnl-3 +In file included from tools.c:16: +../include/ipc.h:26:25: warning: ISO C forbids zero-size array '____payload' [-Wpedantic] + 26 | unsigned char ____payload[0]; + | ^~~~~~~~~~~ +config_parser.c: In function 'is_a_key_value': +config_parser.c:106:45: warning: pointer targets in passing argument 1 of 'cp_printable' differ in signedness [-Wpointer-sign] + 106 | is_key_value = cp_printable(entry) && !cp_smbconf_eol(entry); + | ^~~~~ + | | + | char * +In file included from config_parser.c:17: +../include/config_parser.h:25:47: note: expected 'unsigned char *' but argument is of type 'char *' + 25 | static inline int cp_printable(unsigned char *p) + | ~~~~~~~~~~~~~~~^ +config_parser.c:121:45: warning: pointer targets in passing argument 1 of 'cp_printable' differ in signedness [-Wpointer-sign] + 121 | is_key_value = cp_printable(entry) || *entry == '\t'; + | ^~~~~ + | | + | char * +../include/config_parser.h:25:47: note: expected 'unsigned char *' but argument is of type 'char *' + 25 | static inline int cp_printable(unsigned char *p) + | ~~~~~~~~~~~~~~~^ +In file included from config_parser.c:18: +config_parser.c: In function '__mmap_parse_file': +../include/tools.h:124:34: warning: ISO C does not support the '%m' gnu_printf format [-Wformat=] + 124 | (f), \ + | ^~~ +../include/tools.h:131:9: note: in expansion of macro 'pr_log' + 131 | pr_log(PR_DEBUG, PRDEBUG f, ##__VA_ARGS__) + | ^~~~~~ +config_parser.c:206:17: note: in expansion of macro 'pr_debug' + 206 | pr_debug("Can't open `%s': %m\n", path); + | ^~~~~~~~ +config_parser.c:231:54: warning: ISO C forbids omitting the middle term of a '?:' expression [-Wpedantic] + 231 | delim = memchr(contents, '\n', len) ?: contents + len; + | ^ +config_parser.c: In function 'cp_parse_subauth': +config_parser.c:821:43: warning: ISO C forbids omitting the middle term of a '?:' expression [-Wpedantic] + 821 | contents ?: "", + | ^ +/bin/sh ../libtool --tag=CC --mode=link gcc -DSYSCONFDIR='"/etc"' -DRUNSTATEDIR='"/run"' -I../include -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -fno-common -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/ksmbd-tools-3.5.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic -Wl,-z,relro -Wl,-z,now -o ksmbd.tools management/tree_conn.o management/user.o management/share.o management/session.o config_parser.o tools.o ../addshare/libaddshare.a ../adduser/libadduser.a ../control/libcontrol.a ../mountd/libmountd.a -lglib-2.0 -lnl-genl-3 -lnl-3 libtool: link: gcc -DSYSCONFDIR=\"/etc\" -DRUNSTATEDIR=\"/run\" -I../include -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -fno-common -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/ksmbd-tools-3.5.2=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -pedantic -Wl,-z -Wl,relro -Wl,-z -Wl,now -o ksmbd.tools management/tree_conn.o management/user.o management/share.o management/session.o config_parser.o tools.o ../addshare/libaddshare.a ../adduser/libadduser.a ../control/libcontrol.a ../mountd/libmountd.a -lglib-2.0 -lnl-genl-3 -lnl-3 -pthread make[3]: Leaving directory '/build/reproducible-path/ksmbd-tools-3.5.2/tools' make[3]: Entering directory '/build/reproducible-path/ksmbd-tools-3.5.2' @@ -1591,7 +1627,7 @@ make[2]: Leaving directory '/build/reproducible-path/ksmbd-tools-3.5.2' make[1]: Leaving directory '/build/reproducible-path/ksmbd-tools-3.5.2' dh_auto_test - make -j22 check "TESTSUITEFLAGS=-j22 --verbose" VERBOSE=1 + make -j10 check "TESTSUITEFLAGS=-j10 --verbose" VERBOSE=1 make[1]: Entering directory '/build/reproducible-path/ksmbd-tools-3.5.2' Making check in addshare make[2]: Entering directory '/build/reproducible-path/ksmbd-tools-3.5.2/addshare' @@ -1689,7 +1725,7 @@ make[2]: Entering directory '/build/reproducible-path/ksmbd-tools-3.5.2/tools' make[3]: Entering directory '/build/reproducible-path/ksmbd-tools-3.5.2/tools' /usr/bin/mkdir -p '/build/reproducible-path/ksmbd-tools-3.5.2/debian/ksmbd-tools/usr/libexec' - /bin/bash ../libtool --mode=install /usr/bin/install -c ksmbd.tools '/build/reproducible-path/ksmbd-tools-3.5.2/debian/ksmbd-tools/usr/libexec' + /bin/sh ../libtool --mode=install /usr/bin/install -c ksmbd.tools '/build/reproducible-path/ksmbd-tools-3.5.2/debian/ksmbd-tools/usr/libexec' libtool: install: /usr/bin/install -c ksmbd.tools /build/reproducible-path/ksmbd-tools-3.5.2/debian/ksmbd-tools/usr/libexec/ksmbd.tools make[3]: Nothing to be done for 'install-data-am'. make[3]: Leaving directory '/build/reproducible-path/ksmbd-tools-3.5.2/tools' @@ -1724,8 +1760,8 @@ dh_gencontrol dh_md5sums dh_builddeb -dpkg-deb: building package 'ksmbd-tools' in '../ksmbd-tools_3.5.2-2_i386.deb'. dpkg-deb: building package 'ksmbd-tools-dbgsym' in '../ksmbd-tools-dbgsym_3.5.2-2_i386.deb'. +dpkg-deb: building package 'ksmbd-tools' in '../ksmbd-tools_3.5.2-2_i386.deb'. dpkg-genbuildinfo --build=binary -O../ksmbd-tools_3.5.2-2_i386.buildinfo dpkg-genchanges --build=binary -O../ksmbd-tools_3.5.2-2_i386.changes dpkg-genchanges: info: binary-only upload (no source code included) @@ -1733,12 +1769,14 @@ dpkg-buildpackage: info: binary-only upload (no source included) dpkg-genchanges: info: not including original source code in upload I: copying local configuration +I: user script /srv/workspace/pbuilder/61333/tmp/hooks/B01_cleanup starting +I: user script /srv/workspace/pbuilder/61333/tmp/hooks/B01_cleanup finished I: unmounting dev/ptmx filesystem I: unmounting dev/pts filesystem I: unmounting dev/shm filesystem I: unmounting proc filesystem I: unmounting sys filesystem I: cleaning the build env -I: removing directory /srv/workspace/pbuilder/92801 and its subdirectories -I: Current time: Sun Jun 15 13:55:30 -12 2025 -I: pbuilder-time-stamp: 1750038930 +I: removing directory /srv/workspace/pbuilder/61333 and its subdirectories +I: Current time: Tue May 14 09:33:29 +14 2024 +I: pbuilder-time-stamp: 1715628809